Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DDLm Set categories to have keys #11

Open
jamesrhester opened this issue May 9, 2022 · 1 comment
Open

Allow DDLm Set categories to have keys #11

jamesrhester opened this issue May 9, 2022 · 1 comment

Comments

@jamesrhester
Copy link

As per the recently accepted multi-block principles [1], a DDLm Set category can have key data names if items in that category can be combined by merging data blocks. ddlm_validate currently flags Set categories with key data names as being in error. I suggest this is removed as an error or an option provided to ignore it.

[1] http://comcifs.github.io/accepted/multi-block-principles

@vaitkus
Copy link
Member

vaitkus commented May 9, 2022

Thank you for the update. The warning messages are actually generated by the cif_ddlm_dic_check script, though the ddlm_validate/cif_validate scripts do not yet properly handle Set categories with keys. I plan to implement changes to both of these scripts in the same branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants