Skip to content

Commit 04f1bfa

Browse files
fix: pass no flags to CLI if no flags to supply
1 parent 7be5c34 commit 04f1bfa

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

.circleci/test-deploy.yml

+3
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ jobs:
6666
version: v0.2.2
6767
- codecov/upload:
6868
flags: string_flag,ENV_VAR_CONTAINING_FLAG
69+
- codecov/upload
6970
environment:
7071
ENV_VAR_CONTAINING_FLAG: env_var_flag
7172
test-linux:
@@ -111,6 +112,7 @@ jobs:
111112
version: v0.2.2
112113
- codecov/upload:
113114
flags: string_flag,ENV_VAR_CONTAINING_FLAG
115+
- codecov/upload
114116
environment:
115117
ENV_VAR_CONTAINING_FLAG: env_var_flag
116118
test-windows:
@@ -134,6 +136,7 @@ jobs:
134136
version: v0.2.2
135137
- codecov/upload:
136138
flags: string_flag,ENV_VAR_CONTAINING_FLAG
139+
- codecov/upload
137140
environment:
138141
ENV_VAR_CONTAINING_FLAG: env_var_flag
139142

src/scripts/upload.sh

+12-1
Original file line numberDiff line numberDiff line change
@@ -29,25 +29,36 @@ for flag in $PARAM_FLAGS; do
2929
done
3030
IFS=$OLDIFS
3131

32+
if [ -n "$FLAGS" ]; then
33+
FLAGS="-F ${FLAGS}"
34+
fi
35+
3236
#create commit
37+
echo "./\"$codecov_filename\" ${PARAM_CLI_ARGS} create-commit -t <redacted>"
38+
3339
./"$codecov_filename" \
3440
${PARAM_CLI_ARGS} \
3541
create-commit \
3642
-t "$(eval echo \$$PARAM_TOKEN)"
3743

3844
#create report
45+
echo "./\"$codecov_filename\" ${PARAM_CLI_ARGS} create-report -t <redacted>"
46+
3947
./"$codecov_filename" \
4048
${PARAM_CLI_ARGS} \
4149
create-report \
4250
-t "$(eval echo \$$PARAM_TOKEN)"
4351

4452
#upload reports
4553
# alpine doesn't allow for indirect expansion
54+
55+
echo "./${codecov_filename} ${PARAM_CLI_ARGS} do-upload -t <redacted> -n \"${PARAM_UPLOAD_NAME}\" ${FLAGS} ${PARAM_UPLOAD_ARGS} ${@}"
56+
4657
./"$codecov_filename" \
4758
${PARAM_CLI_ARGS} \
4859
do-upload \
4960
-t "$(eval echo \$$PARAM_TOKEN)" \
5061
-n "${PARAM_UPLOAD_NAME}" \
51-
-F "${FLAGS}" \
62+
${FLAGS} \
5263
${PARAM_UPLOAD_ARGS} \
5364
${@}

0 commit comments

Comments
 (0)