-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The base commit is incorrect and 10+ months old #123
Comments
Is this the right place, or should I open a support request at https://community.codecov.com/? |
Thank you for posting this. I noticed the same issue with my PR (same project) open-telemetry/opamp-go#209 It's impossible to make use of the information when it compares coverage to an arbitrary old commit. |
Hello @rohan-at-sentry / @thomasrockhu-codecov, can we get some help here? Is this a bug or misconfiguration from the original repo side? |
Thanks for raising this @srikanthccv . Was the base commit from last year, Nov 18th the last time the project uploaded coverage successfully? |
@rohan-at-sentry how can I get what was the last commit that had coverage uploaded successfully? This is the output of the recent upload job on the main branch. The repo is https://github.com/open-telemetry/opamp-go. I see that some output URL contains
|
@srikanthccv something feels off here. If you look at the codecov UI for the project, it seems like we're last seeing successfully processed reports from commits 8 months ago https://app.codecov.io/gh/open-telemetry/opamp-go/commits @drazisil-codecov can you take a look here when you're in tomorrow? |
Thanks @rohan-at-sentry. Seems like https://app.codecov.io/github/tigrannajaryan/opamp-go/commits has the most recent successful uploads instead of https://app.codecov.io/github/open-telemetry/opamp-go/commits. I suspect it could be because of the token used? but I will check with the project maintainers once. |
@andykellr I see a similar issue with the example you linked as well |
@rohan-at-sentry we have a new commit that got uploaded to codecov under the correct account https://app.codecov.io/gh/open-telemetry/opamp-go/commits but the didn't make any difference. We would really appreciate it if you could help us figure out what's happening and change the base commit to the latest main. |
When are you uploading coverage? On all commits, or only on PRs? |
@drazisil-codecov On pull request and on push to main. |
Can you link me the latest PR on codecov.io, please? It's looks like you are experiencing missing base commits, which would explain why Codecov reaches so far back to find a base to use. |
Here is a one such PR https://app.codecov.io/gh/open-telemetry/opamp-go/pull/240 which uses the incorrect base base efddaa2 What we noticed was the commits on this https://app.codecov.io/gh/tigrannajaryan/opamp-go/commits had the correct reports uploaded but they were supposed to be here https://app.codecov.io/gh/open-telemetry/opamp-go/commits |
Were you able to confirm you were using the correct upload token? Was that maybe from running the CI as a fork? How to you pass the token to the uploader? |
Yes, we made sure it was using the correct token
How to verify or disprove this?
GitHub secrets which are provided to codecov during actions run |
If it's being passed as an repo secret then a fork would not have access, I believe. I think it may have been a case of fixing whatever was not uploading from main. https://app.codecov.io/gh/open-telemetry/opamp-go/pull/244 looks ok. Can you let me know if your next PR does as well? |
Thank you, let me check and get back. |
@srikanthccv @andykellr I'm closing this issue. If it persists, please let us know |
Hi,
The project https://github.com/open-telemetry/opamp-go uses this action (Workflow config https://github.com/open-telemetry/opamp-go/blob/c1931d7bacc7424e274e5bbdb47ab16829c438de/.github/workflows/build-and-test.yml#L101-L109) for coverage reporting and tracking.
Coverage report on the most recent PR merged to main open-telemetry/opamp-go#207 shows 71.58% (-4.54%) compared to open-telemetry/opamp-go@efddaa2. However, the base commit used for comparison is from last year, Nov 18th. Similarly, for the PRs which are yet to be merged, I assumed they would be compared against the main, i.e. open-telemetry/opamp-go@c1931d7 but these runs also use
efddaa
which is incorrect. Here is an example PR that has a wrong base commit: open-telemetry/opamp-go#192.The text was updated successfully, but these errors were encountered: