Skip to content

Commit 9de9856

Browse files
authored
refactor: Fix phpstan isset.offset (#9383)
1 parent 72b7f8a commit 9de9856

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

system/Database/BaseBuilder.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -3175,6 +3175,7 @@ protected function compileWhereHaving(string $qbKey): string
31753175
) {
31763176
continue;
31773177
}
3178+
31783179
// $matches = [
31793180
// 0 => '(test <= foo)', /* the whole thing */
31803181
// 1 => '(', /* optional */
@@ -3184,7 +3185,7 @@ protected function compileWhereHaving(string $qbKey): string
31843185
// 5 => ')' /* optional */
31853186
// ];
31863187

3187-
if (isset($matches[4]) && $matches[4] !== '') {
3188+
if ($matches[4] !== '') {
31883189
$protectIdentifiers = false;
31893190
if (str_contains($matches[4], '.')) {
31903191
$protectIdentifiers = true;

utils/phpstan-baseline/isset.offset.neon

-8
This file was deleted.

utils/phpstan-baseline/loader.neon

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ includes:
1616
- empty.property.neon
1717
- function.alreadyNarrowedType.neon
1818
- generator.valueType.neon
19-
- isset.offset.neon
2019
- isset.property.neon
2120
- method.alreadyNarrowedType.neon
2221
- method.childParameterType.neon

0 commit comments

Comments
 (0)