Remove a bunch of barely used fields to save memory

Author: frmdstryr

CHANGELOG.md

@@ -1,3 +1,16 @@
+# 0.13.0
+- **BREAKING** Refactor Tag and implementation to significantly reduce memory usage
+- The Tag's `tag` is now a ClassVar instead of an atom member. Use a subclass to change tags.
+- The Tag's `clickable` and `draggable` are now removed. `clickable` is automatically inferred if a `clicked` handler is defined. `draggable` is inferred if `dragstart` is defined. 
+- Due to their minimal usage `onclick`, `ondragstart`, `ondragover`, `ondragend`, `ondragenter` and `ondragleave` are removed. Use
+the `attrs` dict to define these instead.
+- The `alt` attribute was moved from `Tag` to `A` and `Img`, for other nodes use the `attrs` dict.
+- The `cls` attributes now only accept strings. These values are now internd to save memory
+- Tags now have a `find_by_id` method to retrieve a node by it's `id` field
+- Fix bug where an item removed attrs dict was not removed from the html
+- Any proxy `set_{attr}` methods now take a second argument that includes the oldvalue.
+- Optimize speedups extension
+
 # 0.12.1
 - Support python 3.13
 - Cleanup type errors and lint errors

tests/test_html.py

@@ -55,16 +55,16 @@ def test_hello_world(app):
     "tag, attr, query",
     (
         ("Div", 'cls = "right"', '//div[@class="right"]'),
-        ("Div", 'cls = ["btn", "btn-large"]', '//div[@class="btn btn-large"]'),
+        ("Div", 'cls = "btn btn-large"', '//div[@class="btn btn-large"]'),
         ("Span", 'style = "float: left;"', '//span[@style="float: left;"]'),
         (
             "Span",
             'style = {"background": "#fff", "color": "blue"}',
             '//span[(@style="background:#fff;color:blue" or '
             '@style="color:blue;background:#fff")]',
         ),
-        ("Li", "clickable = True", '//li[@clickable="true"]'),
-        ("Li", "draggable = True", '//li[@draggable="true"]'),
+        ("Li", "clicked :: print('clicked')", '//li[@clickable="true"]'),
+        ("Li", "dragstart :: print('dragstart')", '//li[@draggable="true"]'),
         ("Img", 'id = "logo"', '//img[@id="logo"]'),
         # Use attrs for special or non-python html attributes
         ("Div", 'attrs = {"data-tooltip":"Tooltip"}', '//div[@data-tooltip="Tooltip"]'),
@@ -99,7 +99,6 @@ def test_html(app, tag, attr, query):
     "tag, attr, default, change, query",
     (
         ("A", "href", '"#"', "/home/", '//a[@href="/home/"]'),
-        ("A", "tag", '"a"', "span", "//span"),  # It's possible to change tags
         ("Base", "href", '"#"', "/home/", '//base[@href="/home/"]'),
         ("Blockquote", "cite", '"1"', "2", '//blockquote[@cite="2"]'),
         ("Img", "width", '"100px"', "100%", '//img[@width="100%"]'),
@@ -127,15 +126,13 @@ def test_html(app, tag, attr, query):
         ("P", "text", '"a"', "b", '//p[text()="b"]'),
         ("P", "tail", '"a"', "b", '//body[text()="b"]'),
         ("A", "attrs", {"data-x": "a"}, {"data-x": "b"}, '//a[@data-x="b"]'),
-        ("Button", "clickable", False, True, '//button[@clickable="true"]'),
-        ("Button", "draggable", True, False, '//button[@draggable="false"]'),
-        ("A", "onclick", '"a"', "b", '//a[@onclick="b"]'),
-        ("A", "ondragstart", '"a"', "b", '//a[@ondragstart="b"]'),
-        ("A", "ondragover", '"a"', "b", '//a[@ondragover="b"]'),
-        ("A", "ondragend", '"a"', "b", '//a[@ondragend="b"]'),
-        ("A", "ondragenter", '"a"', "b", '//a[@ondragenter="b"]'),
-        ("A", "ondragleave", '"a"', "b", '//a[@ondragleave="b"]'),
-        ("A", "ondrop", '"a"', "b", '//a[@ondrop="b"]'),
+        (
+            "A",
+            "attrs",
+            {"data-x": "a"},
+            {"data-y": "b"},
+            '//a[@data-y="b" and not(@data-x)]',
+        ),
     ),
 )
 def test_html_change(app, tag, attr, default, change, query):
@@ -313,7 +310,7 @@ def test_markdown_proxy(app):
         "extensions_config",
     ):
         with pytest.raises(NotImplementedError):
-            getattr(proxy, "set_%s" % attr)(None)
+            getattr(proxy, "set_%s" % attr)(None, None)
 
 
 def test_code(app):
@@ -358,7 +355,7 @@ def test_code_proxy(app):
     proxy = ProxyCode()
     for attr in ("language", "highlight_style"):
         with pytest.raises(NotImplementedError):
-            getattr(proxy, "set_%s" % attr)(None)
+            getattr(proxy, "set_%s" % attr)(None, None)
 
 
 @pytest.mark.skipif(SKIP_NBFORMAT, reason="nbformat is required")

tests/test_utils.py

@@ -3,6 +3,13 @@
 from web.components.html import Tag
 
 
+def test_intern_str():
+    # Python normally does not intern anything that doesn't look like an attribute
+    # Since cls names are likely to be reused they are automatically interned to save space
+    t1 = Tag(cls="ms-2")
+    assert t1.cls is "ms-2"  # noqa: F632
+
+
 def test_child_index():
     with pytest.raises(ValueError):
         lookup_child_index(None)

web/components/code.py

@@ -19,10 +19,10 @@ class ProxyCode(ProxyRawNode):
     #: Reference to the declaration
     declaration = ForwardTyped(lambda: Code)
 
-    def set_language(self, language: str):
+    def set_language(self, language: str, oldvalue: str):
         raise NotImplementedError
 
-    def set_highlight_style(self, style: str):
+    def set_highlight_style(self, style: str, oldvalue: str):
         raise NotImplementedError