-
Notifications
You must be signed in to change notification settings - Fork 8
Closed
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request
Description
Issues in the code (of password_validator.py
):
- Missing return False: Many methods lacked a return False, causing them to return None and break logical checks.
- Limited special character regex: [_@$] was too restrictive; it excluded many common special characters.
- Non-PEP8 naming: Method names used CamelCase instead of Pythonic snake_case.
- Unsafe default argument: list_values used a mutable default (list), which is unsafe.
- Assumed read_file existence: Used self.read_file() without confirming its presence in BaseValidator.
I have fixed the code, guide me on the next steps.
codeperfectplus
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request