Skip to content

Fixing Password & Array Validator #17

@bandirevanth

Description

@bandirevanth

Issues in the code (of password_validator.py):

  • Missing return False: Many methods lacked a return False, causing them to return None and break logical checks.
  • Limited special character regex: [_@$] was too restrictive; it excluded many common special characters.
  • Non-PEP8 naming: Method names used CamelCase instead of Pythonic snake_case.
  • Unsafe default argument: list_values used a mutable default (list), which is unsafe.
  • Assumed read_file existence: Used self.read_file() without confirming its presence in BaseValidator.

I have fixed the code, guide me on the next steps.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingenhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions