this url.Parse is actually OK

Author: johnstcn

git/git_test.go

@@ -21,7 +21,6 @@ import (
 	"github.com/go-git/go-billy/v5"
 	"github.com/go-git/go-billy/v5/memfs"
 	"github.com/go-git/go-billy/v5/osfs"
-	gittransport "github.com/go-git/go-git/v5/plumbing/transport"
 	githttp "github.com/go-git/go-git/v5/plumbing/transport/http"
 	gitssh "github.com/go-git/go-git/v5/plumbing/transport/ssh"
 	"github.com/stretchr/testify/require"
@@ -141,9 +140,9 @@ func TestCloneRepo(t *testing.T) {
 				authMW := mwtest.BasicAuthMW(tc.srvUsername, tc.srvPassword)
 				srv := httptest.NewServer(authMW(gittest.NewServer(srvFS)))
 
-				authURL, err := gittransport.NewEndpoint(srv.URL)
+				authURL, err := url.Parse(srv.URL)
 				require.NoError(t, err)
-				authURL.User = url.UserPassword(tc.username, tc.password).String()
+				authURL.User = url.UserPassword(tc.username, tc.password)
 				clientFS := memfs.New()
 
 				cloned, err := git.CloneRepo(context.Background(), t.Logf, git.CloneRepoOptions{