Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job relevance ensurer not working properly #2

Open
GianVag opened this issue Nov 7, 2022 · 0 comments
Open

Job relevance ensurer not working properly #2

GianVag opened this issue Nov 7, 2022 · 0 comments

Comments

@GianVag
Copy link

GianVag commented Nov 7, 2022

Hello,

I am using your package for notifications and is working properly.
Now I wanted to use the package for jobs but didn't have any success.

I am using Laravel 6 and dispatching jobs using TestJob::dispatch() on a database queue.
No matter what I tried the job still gets handled, so far I tried:

  1. Just returning false in the isRelevant function (job is still handled)
  2. Modifying the EnsureJobRelevance.php handle function to only return false (job is still handled)
  3. Logged the get_class($event->job) and gotten "Illuminate\Queue\Jobs\DatabaseJob"
  4. Logged the class_implements($event->job) and gotten "Illuminate\Contracts\Queue\Job" meaning the instanceof ShouldBeRelevantJob is false hence isRelevant() is not called.

Sorry if I am missing something
Best Regards
Vagelis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant