Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's not send "incomplete donation" email if it's incomplete due to backend errors #1

Open
cellio opened this issue Dec 12, 2021 · 0 comments

Comments

@cellio
Copy link
Member

cellio commented Dec 12, 2021

If a logged-in user starts a donation but doesn't complete it, we (once) send email about it. The email is well-written and not naggy, but it does assume that the incomplete transaction was the user's doing. ​I think we intended it for the case where the user might have meant to complete the transaction and maybe even thought it was complete (missed a final click).

We recently had some problems with Stripe, so users trying to make donations got error messages. Then they got email asking about the incomplete transaction. Beyond Stripe errors, we could theoretically have some other server error, like the API call failing or timing out or something. Can we not send the email if the attempted donation produced an error?

I really hope this is a rare occurrence, but it's also something that can aggravate the affected people. Can we add this check to our send-email logic?

@cellio cellio transferred this issue from codidact/qpixel Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant