Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent references to post history entries & pagination #1229

Open
Oaphi opened this issue Oct 30, 2023 · 0 comments · May be fixed by #1230
Open

Persistent references to post history entries & pagination #1229

Oaphi opened this issue Oct 30, 2023 · 0 comments · May be fixed by #1230
Assignees
@Oaphi
Labels
area: html/css/js Changes to front-end code area: ruby Changes to server-side code complexity: average Not particularly hard, not particularly trivial. priority: medium

Comments

@Oaphi
Copy link
Member

Oaphi commented Oct 30, 2023 •
edited by cellio
Loading

Also reported: https://meta.codidact.com/posts/291622

Describe the bug

The issue is two-fold:

  1. If the number of history entries for a given post exceeds the number of items per page, there's no UI to navigate to the rest of the entries.
  2. Links to history entries rely on indices which makes them not true permalinks as what constitutes an Nth entry is determined on the fly and is page-relative.

To Reproduce

Opening any history view for a post with more than 20 history entries, for example, https://codegolf.codidact.com/posts/287238/history.

Expected behavior

  1. Pagination component present.
  2. Immutable links to history entries.

Additional context

Special thanks to @trichoplax for noticing the issue.
@Oaphi Oaphi self-assigned this Oct 30, 2023
@Oaphi Oaphi added area: ruby Changes to server-side code area: html/css/js Changes to front-end code priority: medium complexity: average Not particularly hard, not particularly trivial. labels Oct 30, 2023
@Oaphi Oaphi linked a pull request Oct 30, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Oaphi Oaphi

Labels
area: html/css/js Changes to front-end code area: ruby Changes to server-side code complexity: average Not particularly hard, not particularly trivial. priority: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Post history pagination & permalinks codidact/qpixel
1 participant
@Oaphi