-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for Docker setup #1430
Draft
Oaphi
wants to merge
35
commits into
develop
Choose a base branch
from
0valt/1398/docker-fixes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oaphi
added
complexity: average
Not particularly hard, not particularly trivial.
area: deployment
Issues in setting up qpixel, containers, etc.
labels
Oct 12, 2024
Oaphi
force-pushed
the
0valt/1398/docker-fixes
branch
from
October 12, 2024 07:46
469dea7
to
86da6b2
Compare
Oaphi
force-pushed
the
0valt/1398/docker-fixes
branch
from
October 12, 2024 07:59
52431e7
to
17d4095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: deployment
Issues in setting up qpixel, containers, etc.
complexity: average
Not particularly hard, not particularly trivial.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1398
This PR is an overhaul of our Docker setup to make it more flexible and resilient. It includes:
restart
policy toon-failure:3
(meaning 3 consequent failures cause containers to exit). Our current policy ofalways
sends containers in a restart loop if there is a fatal error, making it hard to debug and resolve issues;version
field from docker-compose (just getting rid of an annoying warning);sleep
command from Docker docs as there is none (probably legacy?);.env
(automatically created by local-setup.sh from compose-env).Rationale for no longer auto-starting Rails when building with Dockerfile.dev:
Rationale for making Dockerfile used for the uwsgi container configurable:
CLIENT_DOCKERFILE
environment variable;docker/Dockerfile
;