Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnatural Early termination of episodes with java.lang.StackOverflowError message #4

Open
hitzkrieg opened this issue Nov 11, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@hitzkrieg
Copy link

I observed some problematic episodes from RunHistory files while training DRRN models on many tasks for simplification_str="". I am attaching handful episodes from Task20
task20_problematic_episodes.txt

There are many instances when the episodes terminate prematurely (isComplete=1) with a score of -1, without a logical reason.
They are accompanied by a java.lang.StackOverflowError message in the freelook, inventory, observation entries.

This seems to happen in runs when with simplification_str="", but not when with simplification_str="easy".

@PeterAJansen
Copy link
Contributor

PeterAJansen commented Nov 22, 2022

Dear @hitzkrieg ,

Thanks for this report. This may be due to an issue with ScienceWorld -- it was tested extensively with the "easy" simplification flag, but it's possible that a randomly exploring agent like the DRRN might have uncovered a bug that's not present in the "easy" version of the game. I will put it on my TODO list to investigate this -- if you have any more reports from other tasks, please attach them. Right now it looks like it's limited to a small selection of cases where the electrical connection action is being used?

thanks,
Peter

@MarcCote MarcCote added the bug Something isn't working label Nov 23, 2022
@hitzkrieg
Copy link
Author

I was training on a handful of tasks, and here are two tasks 13, and 20 where I encountered such logs:
https://drive.google.com/drive/folders/1djeLJjt99VY74h3egIbIufB25bqgH2g_?usp=sharing

Yes, it looks like these errors crop up during or after an electrical connection action.

@MarcCote
Copy link
Collaborator

MarcCote commented Dec 9, 2022

@hitzkrieg can you try allenai/ScienceWorld#41 and see if that solves the issue for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants