renderer: Flush states when changing depth comparison mode

Author: cohaereo

CHANGELOG.md

@@ -88,6 +88,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/)
 - Fixed a stack overflow in debug mode by moving global scopes/pipelines to the heap
 - When a texture handle is explicitly set to `none`, Alkahest will now properly unset the texture instead of binding the fallback texture
 - Bake rustc version as a constant instead of checking it at runtime
+- Fixed solid geometry not rendering in simpler maps (Shard, Sunken, etc.)
 
 ## 0.5.0 - 2024-07-24
 

crates/alkahest-renderer/src/gpu/mod.rs

@@ -73,7 +73,7 @@ pub struct GpuContext {
     current_depth_bias: AtomicUsize,
     current_input_topology: AtomicI32,
     current_depth_state: AtomicUsize,
-    pub use_flipped_depth_comparison: AtomicBool,
+    use_flipped_depth_comparison: AtomicBool,
 
     pub current_states: AtomicCell<StateSelection>,
 
@@ -373,6 +373,14 @@ impl GpuContext {
         }
     }
 
+    pub fn set_depth_mode(&self, mode: DepthMode) {
+        let flipped = mode == DepthMode::Flipped;
+        self.use_flipped_depth_comparison
+            .store(flipped, Ordering::Relaxed);
+        // cohae: Since the depth/stencil state only checks the index and not whether we changed the flipped state, we need to flush the depth state manually
+        self.flush_states();
+    }
+
     pub fn present(&self, vsync: bool) {
         if let Some(swap_chain) = &self.swap_chain {
             unsafe {
@@ -559,3 +567,10 @@ impl GpuContext {
 
 unsafe impl Send for GpuContext {}
 unsafe impl Sync for GpuContext {}
+
+#[derive(PartialEq)]
+pub enum DepthMode {
+    Normal,
+    /// Used for rendering shadowmaps
+    Flipped,
+}

crates/alkahest-renderer/src/renderer/shadows.rs

@@ -14,6 +14,7 @@ use crate::{
         visibility::{ViewVisibility, VisibilityHelper},
         Scene,
     },
+    gpu::DepthMode,
     gpu_event, gpu_profile_event,
     renderer::Renderer,
     util::{black_magic::EntityRefDarkMagic, Hocus},
@@ -25,9 +26,7 @@ impl Renderer {
             return;
         }
 
-        self.gpu
-            .use_flipped_depth_comparison
-            .store(true, Ordering::Relaxed);
+        self.gpu.set_depth_mode(DepthMode::Flipped);
 
         gpu_profile_event!(self.gpu, "update_shadow_maps");
         self.gpu
@@ -80,9 +79,7 @@ impl Renderer {
             self.run_renderstage_systems(scene, TfxRenderStage::ShadowGenerate);
         }
 
-        self.gpu
-            .use_flipped_depth_comparison
-            .store(false, Ordering::Relaxed);
+        self.gpu.set_depth_mode(DepthMode::Normal);
     }
 }