Update to mesh-specifications v1.4.15 #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump OpenAPI Generator from older version to v5.4.0 - Update codegen.sh to exclude new utility files (utils.go, error.go, helpers.go, impl.go) - Update Go version from 1.19 to 1.23 in codegen script - Generated code now includes improved nullable type handling fix: resolve NullableCase type issue with OpenAPI Generator v5.4.0 The newer generator incorrectly generates *NullableCase references for nullable enum types, but doesn't create the NullableCase type itself. Added sed command to convert *NullableCase back to *Case to maintain compatibility.
✅ Heimdall Review Status
|
rafalio-cb
force-pushed
the
rafalio/mesh-sdk-go_update_spec_1750215563
branch
from
8c70d44 to
6cd961b
Compare
rafalio-cb
changed the title
rafalio-cb
commented
Jun 20, 2025
| Tweedle CurveType = "tweedle" | ||
| Pallas CurveType = "pallas" | ||
| Secp256k1 CurveType = "secp256k1" | ||
| Secp256k1_BIP340 CurveType = "secp256k1_bip340" |
There was a problem hiding this comment.
Adds the new CurveType
rafalio-cb
commented
Jun 20, 2025
| @@ -33,5 +33,5 @@ type NetworkStatusResponse struct { | |||
| GenesisBlockIdentifier *BlockIdentifier `json:"genesis_block_identifier"` | |||
| OldestBlockIdentifier *BlockIdentifier `json:"oldest_block_identifier,omitempty"` | |||
| SyncStatus *SyncStatus `json:"sync_status,omitempty"` | |||
| Peers []*Peer `json:"peers"` | |||
| Peers []*Peer `json:"peers,omitempty"` | |||
There was a problem hiding this comment.
From previous mesh-specifications updates which made it non-mandatory
rafalio-cb
commented
Jun 20, 2025
| @@ -33,5 +35,6 @@ const ( | |||
| EcdsaRecovery SignatureType = "ecdsa_recovery" | |||
| Ed25519 SignatureType = "ed25519" | |||
| Schnorr1 SignatureType = "schnorr_1" | |||
| SCHNORR_BIP340 SignatureType = "schnorr_bip340" | |||
ningcb
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to mesh-specification v1.4.15 which includes bip340 types.
Updates version of openapi generator (old one doesn't even have arm64 image to run on mac)
We should have done this long ago, we were even asked here Update mesh-specifications to v1.4.15 #500 but then didn't have traction.
I split it into a commit that does just the copright year update for easier review