Skip to content

Times sampling or divides in the Capon method of minvar function. #78

@xifenglu

Description

@xifenglu

1. Describe the bug
A clear and concise description of what the bug is.

2. To Reproduce
If you are facing a bug or installation problem, I cannot help yo without some information of way to reproduce the errors. Please complete the following information as much as possible

  • OS: [e.g. Fedora, windows version, mac version]
  • Python version. for example 3.7.2 (please provide X.Y.Z numbers)
  • Version of spectrum:

you can figure out the version using this python code::

import spectrum
spectrum.version

3.Expected behavior
A clear and concise description of what you expected to happen.

4.Screenshots
If applicable, add screenshots to help explain your problem.

5.What you think may explain the pbl

I like this module and it is so powerful. I have one question/confusion.

math:: P_{MV}(f) = \frac{T}{e^H(f) R^{-1}p e(f)}
def minvar(X, order, sampling=1., NFFT=default_NFFT):
.. math:: P
{MV}(f) = \frac{T}{e^H(f) R^{-1}_p e(f)}
......
# Invert the psi terms at this point to get PSD values
PSD = sampling / np.real(psi)

It times T in the math, but it times sampling in the PSD calculation inside the minvar function. I believe T=1/sampling. When sampling=1, there is no problem. If sampling !=1, it will get wrong answer for power or PSD. I may misunderstand, but can you please verify that.

Thanks.

Steve

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions