Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call not swallowing exceptions #166

Closed
TrevorHinesley opened this issue Apr 21, 2019 · 1 comment · May be fixed by #168
Closed

Call not swallowing exceptions #166

TrevorHinesley opened this issue Apr 21, 2019 · 1 comment · May be fixed by #168

Comments

@TrevorHinesley
Copy link

TrevorHinesley commented Apr 21, 2019 •
edited
Loading

Per the documentation:

This works because the call class method swallows exceptions.

Unless I'm missing something, any errors should be swallowed by call, but they're being raised for me unless I manually catch the error inside call and throw it with fail!
@joevandyk
Copy link

Only Interactor::Failure exceptions are automatically caught. Docs could probably be updated to read “these exceptions” to be clearer.

joevandyk added a commit to joevandyk/interactor that referenced this issue May 19, 2019
@joevandyk
Clarifies Readme about exception handling
25d14e7 
Fixes collectiveidea#166
@joevandyk joevandyk mentioned this issue May 19, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify Readme about exception handling joevandyk/interactor
2 participants
@joevandyk @TrevorHinesley