plain schema() definition: exclude parent props from initialize method

Author: endel

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@colyseus/schema",
-  "version": "3.0.71",
+  "version": "3.0.72",
   "description": "Binary state serializer with delta encoding for games",
   "bin": {
     "schema-codegen": "bin/schema-codegen",

src/annotations.ts

@@ -637,14 +637,27 @@ export function schema<
         return defaults;
     };
 
+    const getParentProps = (props: any) => {
+        const fieldNames = Object.keys(fields);
+        const parentProps: any = {};
+        for (const key in props) {
+            if (!fieldNames.includes(key)) {
+                parentProps[key] = props[key];
+            }
+        }
+        return parentProps;
+    }
+
     /** @codegen-ignore */
     const klass = Metadata.setFields<any>(class extends (inherits as any) {
         constructor(...args: any[]) {
-            super(Object.assign({}, getDefaultValues(), args[0] || {}));
-
             // call initialize method
             if (methods.initialize && typeof methods.initialize === 'function') {
+                super(Object.assign({}, getDefaultValues(), getParentProps(args[0] || {})));
                 methods.initialize.apply(this, args);
+
+            } else {
+                super(Object.assign({}, getDefaultValues(), args[0] || {}));
             }
         }
     }, fields) as SchemaWithExtendsConstructor<T, ExtractInitProps<T>, P>;

test/Definition.test.ts

@@ -675,6 +675,41 @@ describe("Definition Tests", () => {
             });
         });
 
+        it("should exclude parent props from initialize method", () => {
+            const StatSchema = schema({
+                value: 'number',
+                initialize(value: number) {
+                    this.value = value;
+                },
+            });
+
+            const EntitySchema = schema({
+                id: 'string',
+                initialize({ id }: any) {
+                    this.id = id;
+                },
+            });
+
+            const LivingEntitySchema = EntitySchema.extends({
+                stats: { map: StatSchema },
+                initialize(props: any) {
+                    EntitySchema.prototype.initialize.call(this, props);
+
+                    for (const [key, value] of Object.entries(props.stats)) {
+                        this.stats.set(key, new StatSchema(value as number));
+                    }
+                },
+            });
+
+            const entity = new LivingEntitySchema({
+                id: '123',
+                stats: { hp: 500, },
+            });
+
+            assert.strictEqual(entity.id, '123');
+            assert.strictEqual(entity.stats.get('hp')?.value, 500);
+        });
+
     });
 
 });