feat(#528): Add SDIService #529
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gleizesDor <[email protected]>
Open
massifben
approved these changes
Jul 11, 2025
Comment on lines
+16
to
+29
| public Stream<TSDI> getSdis(TDOI tdoi) { | ||
| return tdoi.getSDIOrDAI() | ||
| .stream() | ||
| .filter(dai -> dai.getClass().equals(TSDI.class)) | ||
| .map(TSDI.class::cast); | ||
| } | ||
|
|
||
| public Stream<TSDI> getFilteredSdis(TDOI tdoi, Predicate<TSDI> tdaiPredicate) { | ||
| return getSdis(tdoi).filter(tdaiPredicate); | ||
| } | ||
|
|
||
| public Optional<TSDI> findSdi(TDOI tdoi, Predicate<TSDI> tdaiPredicate) { | ||
| return getFilteredSdis(tdoi, tdaiPredicate).findFirst(); | ||
| } |
There was a problem hiding this comment.
We can have SDI under SDI. Maybe we could also add these methods :
Stream<TSDI> getSdis(TSDI tsdi)
Stream<TSDI> getFilteredSdis(TSDI tsdi, Predicate<TSDI> tsdiPredicate)
Optional<TSDI> findSdi(TSDI tsdi, Predicate<TSDI> tsdiPredicate)
| return getSdis(tdoi).filter(tdaiPredicate); | ||
| } | ||
|
|
||
| public Optional<TSDI> findSdi(TDOI tdoi, Predicate<TSDI> tdaiPredicate) { |
There was a problem hiding this comment.
tsdiPredicate instead of tdaiPredicate
| .map(TSDI.class::cast); | ||
| } | ||
|
|
||
| public Stream<TSDI> getFilteredSdis(TDOI tdoi, Predicate<TSDI> tdaiPredicate) { |
There was a problem hiding this comment.
tsdiPredicate instead of tdaiPredicate
| public Stream<TDAI> getDais(TSDI tsdi) { | ||
| return tsdi.getSDIOrDAI() | ||
| .stream() | ||
| .filter(dai -> dai.getClass().equals(TDAI.class)) |
There was a problem hiding this comment.
Suggested change
| .filter(dai -> dai.getClass().equals(TDAI.class)) | |
| .filter(TDAI.class::isInstance) |
| public Stream<TSDI> getSdis(TDOI tdoi) { | ||
| return tdoi.getSDIOrDAI() | ||
| .stream() | ||
| .filter(dai -> dai.getClass().equals(TSDI.class)) |
There was a problem hiding this comment.
Suggested change
| .filter(dai -> dai.getClass().equals(TSDI.class)) | |
| .filter(TSDI.class::isInstance) |
massifben
reviewed
Jul 11, 2025
| import java.util.function.Predicate; | ||
| import java.util.stream.Stream; | ||
|
|
||
| public class SdiService { |
There was a problem hiding this comment.
Can you add some tests ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SDIService
close #528