`asb` wallet inaccessible after refreshing it with `monero-wallet-cli`

[icy-ux]

Describe the bug
After accessing the asb wallet (asb-wallet) using monero-wallet-cli, asb is no longer able to access the wallet. This persists even after monero-wallet-rpc has been restarted, and after the entire machine has been restarted.

As part of troubleshooting #1061 I refreshed the wallet with monero-wallet-cli. This worked, but now I can't run asb anymore.

Lost/trapped Funds
No

Debug logs

2023-01-09T13:59:57.426024255Z DEBUG Opening Monero wallet
Error: Unable to create Monero wallet, please ensure that the monero-wallet-rpc is available

Caused by:
    0: JSON-RPC request failed with code -21: Cannot create wallet. Already exists.
    1: JSON-RPC request failed with code -21: Cannot create wallet. Already exists.

Platform:

• ASB
• Software Version asb 0.12.0
• Operating System: Debian 11.6

[delta1]

Thanks for the report. When you open the wallet with the monero-wallet-cli did it make you set a password?

[icy-ux]

On Tue, Jan 10, 2023 at 02:50:19AM -0800, Byron Hambly wrote: Thanks for the report. When you open the wallet with the monero-wallet-cli did it make you set a password?

No it did not, at least not as far as I can recall. Since I restarted the server I don't have terminal logs anymore. I do know it asked for a password and I successfully used a blank password ("just press enter").

[delta1]

Thanks yeah confirmed that it's an empty password. Busy investigating further, trying to reproduce. Any logs from monero-wallet-rpc?

[icy-ux]

Nothing in journalctl -u monero-wallet-rpc. There are no relevant logs in /var/log/monero/. Should I look somewhere else?

[icy-ux]

Found a monero-wallet-rpc.log, which contained the following relevant if unhelpful entry:

2023-01-10 11:08:03.427 [RPC0]  ERROR   wallet.wallet2  src/wallet/wallet2.cpp:4744     boost::filesystem::exists(m_wallet_file, ignored_ec). THROW EXCEPTION: error::file_exists
2023-01-10 11:08:05.480 [RPC0]  ERROR   wallet.wallet2  src/wallet/wallet2.cpp:4744     boost::filesystem::exists(m_wallet_file, ignored_ec). THROW EXCEPTION: error::file_exists

Basically asb is trying to create the wallet after failing to open it, but that's expected behaviour when it fails to open a wallet. What we want to know is why the wallet opening failed in the first place...

One potential clue: monero-wallet-rpc seems to be automatically loading the wallet file:

2023-01-10 11:08:00.843 [RPC0]  WARNING wallet.wallet2  src/wallet/wallet2.cpp:5642     Loaded wallet keys file, with public address: 4redacted

This is happening even after restart, I guess because something somewhere has cached the (blank) password?

monero-wallet-rpc also seems to be looping:

2023-01-10 11:12:46.647 [RPC0]  WARNING wallet.wallet2  src/wallet/wallet2.cpp:5642     Loaded wallet keys file, with public address: 4redacted
2023-01-10 11:12:46.705 [RPC0]  WARNING wallet.wallet2  src/wallet/wallet2.cpp:5737     Failed to open portable binary, trying unportable
2023-01-10 11:12:46.750 [RPC0]  WARNING wallet.wallet2  src/wallet/wallet2.cpp:5759     Failed to open portable binary, trying unportable
2023-01-10 11:12:47.751 [RPC0]  ERROR   wallet.wallet2  src/wallet/wallet2.cpp:4744     boost::filesystem::exists(m_wallet_file, ignored_ec). THROW EXCEPTION: error::file_exists
2023-01-10 11:12:53.789 [RPC0]  WARNING wallet.wallet2  src/wallet/wallet2.cpp:5642     Loaded wallet keys file, with public address: 4redacted
2023-01-10 11:12:53.846 [RPC0]  WARNING wallet.wallet2  src/wallet/wallet2.cpp:5737     Failed to open portable binary, trying unportable
2023-01-10 11:12:54.069 [RPC0]  WARNING wallet.wallet2  src/wallet/wallet2.cpp:5759     Failed to open portable binary, trying unportable
2023-01-10 11:12:58.233 [RPC0]  ERROR   wallet.wallet2  src/wallet/wallet2.cpp:4744     boost::filesystem::exists(m_wallet_file, ignored_ec). THROW EXCEPTION: error::file_exists

This is happening regardless of whether asb is running, I think.

[icy-ux]

Ah, I had asb running as a systemd service and it was failing to start, thus the repeated tries in the monero-wallet-rpc log.

[icy-ux]

Stopped the asb systemd service. Restarted monero-wallet-rpc. Ran asb again. Same issue.

Appears monero-wallet-rpc is loading the wallet successfully (!!!) after asb fails.

Here asb fails at :52 ...

2023-01-10T11:21:52.839216578Z DEBUG Opening Monero wallet
Error: Unable to create Monero wallet, please ensure that the monero-wallet-rpc is available

Caused by:
    0: JSON-RPC request failed with code -21: Cannot create wallet. Already exists.
    1: JSON-RPC request failed with code -21: Cannot create wallet. Already exists.

And here monero-wallet-rpc succeeds at opening the wallet at :54, having started at :39...

2023-01-10 11:21:39.657     7f1268e8d7c0        WARNING wallet.rpc      src/wallet/wallet_rpc_server.cpp:4559   Starting wallet RPC server
2023-01-10 11:21:54.006 [RPC0]  WARNING wallet.wallet2  src/wallet/wallet2.cpp:5642     Loaded wallet keys file, with public address: 4redacted

@delta1 Can it be that asb simply needs a longer timeout when loading an existing wallet?

[delta1]

I'm not reproducing this on the latest master.

• stopped monero-wallet-rpc
• opened the asb-wallet with monero-wallet-cli version 0.18.1.2
• ran set_daemon and refresh successfully
• started monero-wallet-rpc
• started asb without issue

I've added a debug log in PR #1274, once that's merged you can use the ASB preview build to get a log message for why that wallet isn't opening. Hopefully it helps us debug this.

[icy-ux]

Thanks. Yes, having a binary will help, I tried building it (on Debian 11.3, Rust 1.62.1) but build failed:

   Compiling bitcoin_hashes v0.11.0                                    
error[E0658]: use of unstable library feature 'array_from_fn'
   --> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/enum-iterator-1.2.0/src/lib.rs:554:18        latest                               
    |                                                                  
554 |             Some(core::array::from_fn(|_| unreachable!()))       
    |                  ^^^^^^^^^^^^^^^^^^^^                                                                                                   
    |                                                                                                                                         
    = note: see issue #89379 <https://github.com/rust-lang/rust/issues/89379> for more information                                            
                                                                                                                                              
error[E0658]: use of unstable library feature 'array_from_fn'          
   --> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/enum-iterator-1.2.0/src/lib.rs:557:18                                       
    |                                                                                                                                         
557 |             Some(core::array::from_fn(|_| x.clone()))                                                                                   
    |                  ^^^^^^^^^^^^^^^^^^^^                                                                                                   
    |                                                                  
    = note: see issue #89379 <https://github.com/rust-lang/rust/issues/89379> for more information                                            
                                                                                                                                              
error[E0658]: use of unstable library feature 'array_from_fn'          
   --> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/enum-iterator-1.2.0/src/lib.rs:563:18                                       
    |                                                                                                                                         
563 |             Some(core::array::from_fn(|_| unreachable!()))       
    |                  ^^^^^^^^^^^^^^^^^^^^                                                                                                   
    |                                                                  
    = note: see issue #89379 <https://github.com/rust-lang/rust/issues/89379> for more information                                            
                                                                                                                                              
error[E0658]: use of unstable library feature 'array_from_fn'          
   --> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/enum-iterator-1.2.0/src/lib.rs:566:18                                       
    |                                                                  
566 |             Some(core::array::from_fn(|_| x.clone()))
    |                  ^^^^^^^^^^^^^^^^^^^^                                                                                                   
    |                                                                                                                                         
    = note: see issue #89379 <https://github.com/rust-lang/rust/issues/89379> for more information                                            
                                                                       
   Compiling serde_urlencoded v0.7.1         

Using +nightly build still fails:

~/xmr/xmr-btc-swap$ cargo +nightly build  --release --bin asb
Compiling swap v0.12.1 (/home/user/xmr/xmr-btc-swap/swap)
error: failed to run custom build command for `swap v0.12.1 (/home/user/xmr/xmr-btc-swap/swap)`

Caused by:
process didn't exit successfully: `/home/user/xmr/xmr-btc-swap/target/release/build/swap-fa5d4a1e85978ad5/build-script-build` (exit status: 1)
--- stderr
Error: could not find repository from '/home/user/xmr/xmr-btc-swap/swap'; class=Repository (6); code=NotFound (-3)

[delta1]

You need Rust stable 1.62 or newer. Strange, you could try a newer Rust stable.

#1274 is merged, please try the binary from the preview build when it's ready

https://github.com/comit-network/xmr-btc-swap/releases/tag/preview

build action run

https://github.com/comit-network/xmr-btc-swap/actions/runs/3883255410

[delta1]

Hmm this slipped in: stephaneyfx/enum-iterator#20

You'll need 1.63 or newer

[icy-ux]

Well, rust-toolchain.toml forces it to the 1.26 channel:

rust-toolchain.toml      
2:channel = "1.62"                                                                                                                            

But even with +nightly, the custom build script at swap/build.rs fails, giving the 2nd error message above.

I downloaded the preview release with wget -c "https://github.com/comit-network/xmr-btc-swap/releases/download/preview/asb_preview_Linux_x86_64.tar" , extracted it, and tried running it. Unfortunately the error message is not helpful:

2023-01-10T12:39:28.145782647Z DEBUG Opening Monero wallet
2023-01-10T12:39:29.568034566Z DEBUG Open wallet response error error=JSON-RPC request failed with code -1: Failed to open wallet
Error: Unable to create Monero wallet, please ensure that the monero-wallet-rpc is available

Caused by:
    0: JSON-RPC request failed with code -21: Cannot create wallet. Already exists.
    1: JSON-RPC request failed with code -21: Cannot create wallet. Already exists.

Here's the corresponding monero-wallet-rpc log entries:

2023-01-10 12:39:29.406 [RPC0]  WARNING wallet.wallet2  src/wallet/wallet2.cpp:5642     Loaded wallet keys file, with public address: 4redacted
2023-01-10 12:39:29.489 [RPC0]  WARNING wallet.wallet2  src/wallet/wallet2.cpp:5737     Failed to open portable binary, trying unportable
2023-01-10 12:39:29.530 [RPC0]  WARNING wallet.wallet2  src/wallet/wallet2.cpp:5759     Failed to open portable binary, trying unportable
2023-01-10 12:39:30.702 [RPC0]  ERROR   wallet.wallet2  src/wallet/wallet2.cpp:4744     boost::filesystem::exists(m_wallet_file, ignored_ec). THROW EXCEPTION: error::file_exists

As we can see, monero-wallet-rpc successfully loaded the wallet keys file at 29.406 while asb failed at 29.568, and the final file_exists error didn't come until 30.702, so I really don't know what's going on here.