Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTROL_START_IDX #12

Closed
omarrayyann opened this issue May 22, 2024 · 1 comment
Closed

CONTROL_START_IDX #12

omarrayyann opened this issue May 22, 2024 · 1 comment

Comments

@omarrayyann
Copy link

omarrayyann commented May 22, 2024 •
edited
Loading

Shouldn't CONTEXT_LENGTH in the reset and rollout functions be replaced with CONTROL_START_IDX

Screenshot 2024-05-22 at 9 23 07 AM
@nuwandavek
Copy link
Contributor

No, I think this is correct? The step_idx needs to be such that the context is filled. But it can be before CONTROL_START_IDX. This is intended to "warm up" the model/controller if necessary. Might make more sense with this: #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nuwandavek @omarrayyann