Skip to content

Commit 27372a0

Browse files
committed
cleanups
1 parent f70b6e0 commit 27372a0

File tree

2 files changed

+19
-22
lines changed

2 files changed

+19
-22
lines changed

src/app/Flash.jsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,8 @@ export default function Flash() {
238238
<div className="w-full max-w-3xl px-8 transition-opacity duration-300" style={{ opacity: progress === -1 ? 0 : 1 }}>
239239
<LinearProgress value={progress * 100} barColor={bgColor} />
240240
</div>
241-
<span className={`text-3xl dark:text-white font-mono font-light`}>{title}</span>
242-
<span className={`text-xl dark:text-white px-8 max-w-xl`}>{description}</span>
241+
<span className="text-3xl dark:text-white font-mono font-light">{title}</span>
242+
<span className="text-xl dark:text-white px-8 max-w-xl">{description}</span>
243243
{error && (
244244
<button
245245
className="px-4 py-2 rounded-md bg-gray-200 hover:bg-gray-300 dark:bg-gray-700 dark:hover:bg-gray-600 text-gray-800 dark:text-gray-200 transition-colors"

src/app/index.jsx

+17-20
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,21 @@ import { isWindows } from '../utils/platform'
99

1010
const Flash = lazy(() => import('./Flash'))
1111

12+
const VENDOR_ID = '18D1'
13+
const PRODUCT_ID = 'D00D'
14+
1215
export default function App() {
1316
const version = import.meta.env.VITE_PUBLIC_GIT_SHA || 'dev'
14-
console.info(`flash.comma.ai version: ${version}`);
17+
console.info(`flash.comma.ai version: ${version}`)
1518
return (
1619
<div className="flex flex-col lg:flex-row flex-wrap">
1720
<main className="p-12 md:p-16 lg:p-20 xl:p-24 w-screen max-w-none lg:max-w-prose lg:w-auto h-auto lg:h-screen lg:overflow-y-auto prose dark:prose-invert prose-green bg-white dark:bg-gray-900">
1821
<section>
1922
<img src={comma} alt="comma" width={128} height={128} className="dark:invert" />
2023
<h1>flash.comma.ai</h1>
21-
22-
<p>This tool allows you to flash AGNOS onto your comma device.</p>
2324
<p>
24-
AGNOS is the Ubuntu-based operating system for your{" "}
25-
<a href="https://comma.ai/shop/comma-3x" target="_blank">comma 3/3X</a>.
25+
This tool allows you to flash AGNOS onto your comma device. AGNOS is the Ubuntu-based operating system for
26+
your <a href="https://comma.ai/shop/comma-3x" target="_blank">comma 3/3X</a>.
2627
</p>
2728
</section>
2829
<hr />
@@ -31,24 +32,23 @@ export default function App() {
3132
<h2>Requirements</h2>
3233
<ul>
3334
<li>
34-
A web browser which supports WebUSB (such as Google Chrome, Microsoft Edge, Opera), running on Windows, macOS, Linux, or Android.
35+
A web browser which supports <a href="https://caniuse.com/webusb" target="_blank">WebUSB</a>
36+
{" "}(such as Google Chrome, Microsoft Edge, Opera), running on Windows, macOS, Linux, or Android.
3537
</li>
3638
<li>
3739
A USB-C cable to power your device outside the car.
3840
</li>
3941
<li>
40-
Another USB-C cable to connect the device to your computer.
42+
A good quality USB-C cable to connect the device to your computer. <span title="SuperSpeed">USB 3</span>
43+
{" "}is recommended for faster flashing speed.
4144
</li>
4245
</ul>
4346
{isWindows && (<>
4447
<h3>USB Driver</h3>
45-
<p>
46-
You need additional driver software for Windows before you connect
47-
your device.
48-
</p>
48+
<p>You need additional driver software for Windows before you connect your device.</p>
4949
<ol>
5050
<li>
51-
Download and install <a href="https://zadig.akeo.ie/">Zadig</a>.
51+
Download and run <a href="https://zadig.akeo.ie/" target="_blank">Zadig</a>.
5252
</li>
5353
<li>
5454
Under <code>Device</code> in the menu bar, select <code>Create New Device</code>.
@@ -60,10 +60,9 @@ export default function App() {
6060
/>
6161
</li>
6262
<li>
63-
Fill in three fields. The first field is just a description and
64-
you can fill in anything. The next two fields are very important.
65-
Fill them in with <code>18D1</code> and <code>D00D</code> respectively.
66-
Press &quot;Install Driver&quot; and give it a few minutes to install.
63+
Fill in three fields. The first field is just a description and you can fill in anything. The next two
64+
fields are very important. Fill them in with <code>{VENDOR_ID}</code> and <code>{PRODUCT_ID}</code>
65+
respectively. Press &quot;Install Driver&quot; and give it a few minutes to install.
6766
<img
6867
src={zadigForm}
6968
alt="Zadig Form"
@@ -72,9 +71,7 @@ export default function App() {
7271
/>
7372
</li>
7473
</ol>
75-
<p>
76-
No additional software is required for macOS or Linux.
77-
</p>
74+
<p>No additional software is required for macOS, Linux or Android.</p>
7875
</>)}
7976
</section>
8077
<hr />
@@ -159,7 +156,7 @@ export default function App() {
159156
</div>
160157

161158
<div className="w-screen max-w-none p-12 md:p-16 prose dark:prose-invert bg-white dark:bg-gray-900 lg:hidden">
162-
flash.comma.ai version: <code>{version.substring(0, 7)}</code>
159+
flash.comma.ai version: <code>{version}</code>
163160
</div>
164161
</div>
165162
)

0 commit comments

Comments
 (0)