Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle routes with no time #60

Open
adeebshihadeh opened this issue Jul 11, 2024 · 5 comments · May be fixed by #69, #112, #391 or #138
Open

Handle routes with no time #60

adeebshihadeh opened this issue Jul 11, 2024 · 5 comments · May be fixed by #69, #112, #391 or #138
Labels
bounty comma.ai/bounties enhancement new feature or request
Milestone

Comments

@adeebshihadeh
Copy link
Contributor

Since openpilot 0.9.7 removed RTC support, some routes can have no time (e.g. the device just booted up and didn't get a GPS fix during the route).

Since openpilot's uploader guarantees that routes are uploaded in the order they were created, we can still show all routes in the correct sequence using the create_time attribute of the route.

Requirements

  • hide the date/time
  • show "timeless" routes in the correct order with the rest of routes
@adeebshihadeh adeebshihadeh added the enhancement new feature or request label Jul 11, 2024
@adeebshihadeh adeebshihadeh added the bounty comma.ai/bounties label Jul 11, 2024
@adeebshihadeh adeebshihadeh added this to the 1.0 milestone Jul 11, 2024
@vishalkrishnads vishalkrishnads linked a pull request Jul 12, 2024 that will close this issue
@eshaanrathi2
Copy link

I would like to work on this. @adeebshihadeh

tex-murphy added a commit to tex-murphy/comma-new-connect that referenced this issue Aug 19, 2024
- falls back to `create_time` when start_time/end_time are unavailable
- refactor `<RouteHeader />` into its own file
- hide `<RouteStatistics />` if there's no trip data

closes commaai#60
@0x41head 0x41head linked a pull request Nov 28, 2024 that will close this issue
@incognitojam
Copy link
Member

incognitojam commented Feb 3, 2025

The /v1/devices/:dongleId/routes_segments endpoint we are using has limit and end params we use to seek backwards through the list of routes. I think we need a new endpoint which sorts by create_time on the server side instead of filtering by the "route end time" (I don't know how this is determined for the timeless routes).

@tybo9
Copy link

tybo9 commented Feb 16, 2025

I forked about this project and would like to have some clarification on where to start.

@adeebshihadeh
Copy link
Contributor Author

The /v1/devices/:dongleId/routes_segments endpoint we are using has limit and end params we use to seek backwards through the list of routes. I think we need a new endpoint which sorts by create_time on the server side instead of filtering by the "route end time" (I don't know how this is determined for the timeless routes).

@sshane can you add this new endpoint and take care of anything else needed on the backend for shipping new connect?

I think we want to add a v1.1 version of this endpoint, then just remove the old one once connect is deprecated. Nothing should use start/end time anymore (unless it's just for UI).

@incognitojam
Copy link
Member

probably doesn't need to change to v1.1 as it's not a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment