engage % is not correct

[BBBmau]

It was quick to realize when looking at the timeline that the engagement percentage did not match up. Grey represents overrides by driver such as pressing on the gas or moving the steering wheel.

My understanding is it's marking one state as two (engaged AND overriding) here's the place where the percentage is being calculated.

new-connect/src/components/RouteStatistics.tsx

Lines 9 to 13 in 84d1b82

	const formatEngagement = (timeline?: TimelineStatistics): string => {
	if (!timeline) return ''
	const { engagedDuration, duration } = timeline
	return `${(100 * (engagedDuration / duration)).toFixed(0)}%`
	}

This is where the state is determined (engaged, overriding, alert, userflag)

new-connect/src/api/derived.ts

Lines 126 to 171 in 84d1b82

	events.forEach((ev) => {
	if (ev.type === 'state') {
	const { enabled, alertStatus, state } = ev.data
	if (lastEngaged && !enabled) {
	res.push({
	type: 'engaged',
	route_offset_millis: lastEngaged.route_offset_millis,
	end_route_offset_millis: ev.route_offset_millis,
	} as EngagedTimelineEvent)
	lastEngaged = undefined
	}
	if (!lastEngaged && enabled) {
	lastEngaged = ev
	}
	if (lastAlert && lastAlert.data.alertStatus !== alertStatus) {
	res.push({
	type: 'alert',
	route_offset_millis: lastAlert.route_offset_millis,
	end_route_offset_millis: ev.route_offset_millis,
	alertStatus: lastAlert.data.alertStatus,
	} as AlertTimelineEvent)
	lastAlert = undefined
	}
	if (!lastAlert && alertStatus !== 0) {
	lastAlert = ev
	}
	if (lastOverride && !isOverriding(ev.data.state)) {
	res.push({
	type: 'overriding',
	route_offset_millis: lastOverride.route_offset_millis,
	end_route_offset_millis: ev.route_offset_millis,
	} as OverridingTimelineEvent)
	lastOverride = undefined
	}
	if (!lastOverride && isOverriding(state)) {
	lastOverride = ev
	}
	} else if (ev.type === 'user_flag') {
	res.push({
	type: 'user_flag',
	route_offset_millis: ev.route_offset_millis,
	})
	}
	})