ui: only instantiate OnboardingWindow when onboarding is needed

[deanlee]

OnboardingWindow is now created only when onboarding is required and destroyed after use, improving startup time, reducing resource usage, and preventing callbacks registered by OnboardingWindow from being triggered unnecessarily during the UI’s lifetime, which could cause unintended side effects.

[github-actions]

raylib UI Preview

All Screenshots

[adeebshihadeh]

Nothing in particular about it should be slow, so I don't think this is the right move to improve startup time. We just need to make font, picture, etc loading way faster.

[sshane]

I agree

[deanlee]

The main reason for lazily creating and destroying OnboardingWindow isn’t startup performance in general — it’s correctness and resource safety.

OnboardingWindow was previously instantiated on every boot. That means:

• A DM CameraView was being created unconditionally, it's not cheap
• Interactive timeout callbacks were registered
• Params like IsDriverViewEnabled could be touched prematurely

These side effects should only run when onboarding is actually needed. Font/texture loading is the real startup bottleneck, but this change fixes incorrect and risky behavior — it’s the right design regardless of performance.

[adeebshihadeh]

• A DM CameraView was being created unconditionally, it's not cheap

Let's make it cheap! What's slow here?

• Interactive timeout callbacks were registered

So?

• Params like IsDriverViewEnabled could be touched prematurely

Why? If this is the case, it sounds like a bug anyway.