Cleanup common and useless debug logs (#2183)

* cleanup common logs

* cleanup puth2

Author: robbederks

board/drivers/harness.h

@@ -100,13 +100,8 @@ void harness_init(void) {
   set_gpio_output(current_board->harness_config->GPIO_relay_SBU1, current_board->harness_config->pin_relay_SBU1, 1);
   set_gpio_output(current_board->harness_config->GPIO_relay_SBU2, current_board->harness_config->pin_relay_SBU2, 1);
 
-  // try to detect orientation
+  // detect initial orientation
   harness.status = harness_detect_orientation();
-  if (harness.status != HARNESS_STATUS_NC) {
-    print("detected car harness with orientation "); puth2(harness.status); print("\n");
-  } else {
-    print("failed to detect car harness!\n");
-  }
 
   // keep buses connected by default
   set_intercept_relay(false, false);

board/drivers/spi.h

@@ -108,7 +108,9 @@ void spi_rx_done(void) {
       response_len = 1U;
     } else {
       // response: NACK and reset state machine
-      print("- incorrect header sync or checksum "); hexdump(spi_buf_rx, SPI_HEADER_SIZE);
+      #ifdef DEBUG_SPI
+        print("- incorrect header sync or checksum "); hexdump(spi_buf_rx, SPI_HEADER_SIZE);
+      #endif
       spi_buf_tx[0] = SPI_NACK;
       next_rx_state = SPI_STATE_HEADER_NACK;
       response_len = 1U;
@@ -160,12 +162,14 @@ void spi_rx_done(void) {
     } else {
       // Checksum was incorrect
       response_ack = false;
-      print("- incorrect data checksum ");
-      puth4(spi_data_len_mosi);
-      print("\n");
-      hexdump(spi_buf_rx, SPI_HEADER_SIZE);
-      hexdump(&(spi_buf_rx[SPI_HEADER_SIZE]), MIN(spi_data_len_mosi, 64));
-      print("\n");
+      #ifdef DEBUG_SPI
+        print("- incorrect data checksum ");
+        puth4(spi_data_len_mosi);
+        print("\n");
+        hexdump(spi_buf_rx, SPI_HEADER_SIZE);
+        hexdump(&(spi_buf_rx[SPI_HEADER_SIZE]), MIN(spi_data_len_mosi, 64));
+        print("\n");
+      #endif
     }
 
     if (!response_ack) {

board/drivers/uart.h

@@ -145,10 +145,6 @@ void puth(unsigned int i) {
   puthx(i, 8U);
 }
 
-void puth2(unsigned int i) {
-  puthx(i, 2U);
-}
-
 #if defined(ENABLE_SPI) || defined(BOOTSTUB) || defined(DEBUG)
 void puth4(unsigned int i) {
   puthx(i, 4U);
@@ -160,7 +156,7 @@ void hexdump(const void *a, int l) {
   if (a != NULL) {
     for (int i=0; i < l; i++) {
       if ((i != 0) && ((i & 0xf) == 0)) print("\n");
-      puth2(((const unsigned char*)a)[i]);
+      puthx(((const unsigned char*)a)[i], 2U);
       print(" ");
     }
   }

board/drivers/uart_declarations.h

@@ -33,7 +33,6 @@ void putch(const char a);
 void print(const char *a);
 void puthx(uint32_t i, uint8_t len);
 void puth(unsigned int i);
-void puth2(unsigned int i);
 #if defined(ENABLE_SPI) || defined(BOOTSTUB) || defined(DEBUG)
 void puth4(unsigned int i);
 #endif

board/drivers/usb.h

@@ -538,21 +538,26 @@ void usb_irqhandler(void) {
   }
 
   if ((gintsts & USB_OTG_GINTSTS_USBRST) != 0U) {
-    print("USB reset\n");
+    #ifdef DEBUG_USB
+      print("USB reset\n");
+    #endif
     usb_reset();
   }
 
   if ((gintsts & USB_OTG_GINTSTS_ENUMDNE) != 0U) {
-    print("enumeration done");
+    #ifdef DEBUG_USB
+      print("enumeration done\n");
+    #endif
     // Full speed, ENUMSPD
     //puth(USBx_DEVICE->DSTS);
-    print("\n");
   }
 
   if ((gintsts & USB_OTG_GINTSTS_OTGINT) != 0U) {
-    print("OTG int:");
-    puth(USBx->GOTGINT);
-    print("\n");
+    #ifdef DEBUG_USB
+      print("OTG int:");
+      puth(USBx->GOTGINT);
+      print("\n");
+    #endif
 
     // getting ADTOCHG
     //USBx->GOTGINT = USBx->GOTGINT;

board/main_declarations.h

@@ -3,7 +3,6 @@
 // ******************** Prototypes ********************
 void print(const char *a);
 void puth(unsigned int i);
-void puth2(unsigned int i);
 void puth4(unsigned int i);
 void hexdump(const void *a, int l);
 typedef struct board board;