Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compas_cgal.slicer.slice_mesh, open versus closed contours #3

Open
ioannaMitropoulou opened this issue Oct 18, 2020 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@ioannaMitropoulou
Copy link

Feature Request

As a user of the package, I want an extension of the compas_cgal.slicer.slice_mesh function so that I can use it for slicing open and closed meshes.

Details

Currently, the slice_mesh function returns a list of arrays that define the slice polylines. However, there is no information regarding whether the polyline represents an open or a closed contour. Instead, it would be nice if it also returned a boolean for example that defines if the first and the last point of each polyline are connected.

Describe alternatives you've considered
We considered having a distance threshold between the first and last points, but that seemed to us impossible to make reliable. So now we consider that all paths are closed, but of course, this limits the shapes that we can apply this method on.

@tomvanmele
Copy link
Member

okay will have a look... using a geometric map for the end points should be a good place to start

@tomvanmele tomvanmele self-assigned this Oct 7, 2022
@tomvanmele tomvanmele added the enhancement New feature or request label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants