Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hf.f #2

Open
cffischer opened this issue Apr 27, 2022 · 4 comments
Open

hf.f #2

cffischer opened this issue Apr 27, 2022 · 4 comments

Comments

@cffischer
Copy link
Member

There is an error in the declaration of OF(30). Since NWFD=20
if should be either OF(20) or OF(NWFD) foe more general declation.

With this declaration Hf compiles only with warnings.

@jongrumer
Copy link
Member

Ok, thanks Charlotte! I'll fix it asap!

@jongrumer
Copy link
Member

jongrumer commented Apr 28, 2022

Ok - I've added patches of both atsp and atsp-book versions of HF:

Will merge this very soon.

@cffischer
Copy link
Member Author

I know OF(20) works but, since this is F77, possibly it shoudl be OF(NWFD=20) instead of OF(NWFD) since NWFD might not be defined in the subroutine.

Just an afterthought

@jongrumer
Copy link
Member

I see what you mean, and I tried that, but it didn't work. Need to come up with another way of implementing such a thing I suppose. We can think about it, need to merge this now (the summer course is starting and the HF workshop is coming up!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants