You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
substituting let variables need some analysis on the nature of the target expressions. Especially, if the expression is Dict type, then we need to have special cares. Unfortunately, Dict can come from different modules from re-export and there are no easy ways to check the equality of those definitions. So in 15465, we have hard-coded two modules Data.Constraint and Barbies.Internal,Dicts, but some other cases may happen in the future, so this should be handled correctly.This may require some change in the ordering of our categorization steps and further module export analysis. So we want to postpone the work until when the approach becomes more clear.
AC:
No more hard-coded re-exported module check in isDictOrBarbiesDictTyCon but detecting such re-export in general way.
Would it be possible to somehow apply Client.Rep and check that type? Barbies.Dict (and any other Dict-like that appears) should have Constraint.Dict as its Rep.
Also, point of clarity – Barbies.Dict isn't a re-export. They're different, roughly
subst
ituting let variables need some analysis on the nature of the target expressions. Especially, if the expression isDict
type, then we need to have special cares. Unfortunately,Dict
can come from different modules from re-export and there are no easy ways to check the equality of those definitions. So in 15465, we have hard-coded two modulesData.Constraint
andBarbies.Internal,Dicts
, but some other cases may happen in the future, so this should be handled correctly.This may require some change in the ordering of our categorization steps and further module export analysis. So we want to postpone the work until when the approach becomes more clear.AC:
No more hard-coded re-exported module check in
isDictOrBarbiesDictTyCon
but detecting such re-export in general way.(Extricated from https://kitty-hawk.atlassian.net/browse/SW-3418)
The text was updated successfully, but these errors were encountered: