Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report when we try to convert a mutually-recursive top-level definition #44

Open
zliu41 opened this issue Apr 15, 2022 · 0 comments
Open

Comments

@zliu41
Copy link
Member

zliu41 commented Apr 15, 2022

Right now categorize simply gets stuck in a loop when we try to categorize a mutually-recursive function.

I think the problem is tied to inlining, so it would be great if we could keep track of what we've inlined, and error if we try to inline a function that we're in the middle of converting already.

The problem with this approach currently is that we usually inline the original expression within a larger unconverted expression, then convert the larger expression, so it's possible that if we just track it in the larger expression that we're noticing parallel invocations of the same function, rather than nested ones.

Perhaps we could manually introduce a Tick node whenever we inline, so then we can notice that we hit the inlined identifier within the larger expression.

(Extricated from https://kitty-hawk.atlassian.net/browse/SW-2733)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant