Skip to content

Conversation

HzaCode
Copy link

@HzaCode HzaCode commented Sep 27, 2025

Description

This PR adds a conda-forge recipe for cheminformant, a robust and high-throughput Python client for the PubChem API.

Package Information

Checklist

  • Title of this PR is meaningful: "Add cheminformant recipe"
  • License file is packaged (LICENSE file is present in source package)
  • Source is from official source (PyPI)
  • Package does not vendor other packages
  • If static libraries are linked in, the license of the static library is packaged (N/A - pure Python package)
  • Package does not ship static libraries (N/A - pure Python package)
  • Build number is 0
  • A tarball (url) rather than a repo is used in recipe (using PyPI tarball)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there (I am the maintainer HzaCode)
  • When in trouble, checked knowledge base documentation

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Sep 27, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cheminformant/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/cheminformant/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use the pin python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).
  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18058194307. Examine the logs at this URL for more detail.

- pystow >=0.7 is not available in conda-forge channel
- This dependency causes build failures in CI
- Added note for users to install pystow separately via pip if needed
- Removed noarch: python because the package generates platform-specific
  console scripts (chemdraw.exe on Windows)
- This fixes the CondaBuildUserError: Noarch package contains binary script
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Sep 27, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cheminformant/meta.yaml) and found some lint.

Here's what I've got...

For recipes/cheminformant/meta.yaml:

  • ❌ Invalid noarch value False. Should be one of python, generic.
  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: False, or selector on line 18:
    skip: true # [py<38]

For recipes/cheminformant/meta.yaml:

  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18058590403. Examine the logs at this URL for more detail.

… constraints, simplify tests

- Set noarch: false for CLI package with platform-specific scripts
- Remove python version constraints from requirements (use skip selector instead)
- Add skip: true [py<38] to ensure Python 3.8+ requirement
- Simplify test configuration to only import testing to avoid CLI execution issues
- Remove invalid 'noarch: false' (valid values are only 'python' or 'generic')
- Keep skip selector for Python 3.8+ requirement
- Package will build for each platform separately (default behavior)
- Update source URL to use recommended pypi.org domain
- Complete all conda-forge linting fixes:
  鉁?Remove invalid noarch: false
  鉁?Fix Python version constraints (use skip selector)
  鉁?Update PyPI URL to pypi.org
  鉁?Simplify test configuration
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cheminformant/meta.yaml) and found it was in an excellent condition.

@HzaCode
Copy link
Author

HzaCode commented Oct 13, 2025

@conda-forge/help-python ready for review!

@HzaCode
Copy link
Author

HzaCode commented Oct 13, 2025

Hello, CI is green. I believe the recipe is ready for review. If there’s anything I need to adjust, happy to do so. @conda-forge/help-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants