Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop a CRM script to scan feedstocks for dependency/import name mis-matches #181

Open
schuylermartin45 opened this issue Oct 4, 2024 · 4 comments · May be fixed by #218
Open

Develop a CRM script to scan feedstocks for dependency/import name mis-matches #181

schuylermartin45 opened this issue Oct 4, 2024 · 4 comments · May be fixed by #218
Assignees
@schuylermartin45
Labels
enhancement New feature or request source::maintainer to sort Needs additional investigation
Milestone
Project: Recipe B...

Comments

@schuylermartin45
Copy link
Collaborator

Credit goes to @cbouss for suggesting this.

We could use CRM to develop a script that scans a large set of feedstock repositories to find cases where the import name does not match the conda package name.

Example: the pillow library uses PIL as the import name.

That could greatly increase the accuracy of the newly introduced PythonDependencyScanner class (see #180)
@schuylermartin45 schuylermartin45 added enhancement New feature or request source::maintainer to sort Needs additional investigation labels Oct 4, 2024
@schuylermartin45 schuylermartin45 moved this from Backlog to Ready in Conda Recipe Manager Oct 4, 2024
@schuylermartin45 schuylermartin45 self-assigned this Oct 4, 2024
@schuylermartin45
Copy link
Collaborator Author

schuylermartin45 commented Oct 8, 2024 •
edited
Loading

This script has been started, but it is unclear if it is worth pursuing when this database exists: https://github.com/regro/cf-graph-countyfair/tree/master/import_to_pkg_maps

@schuylermartin45 schuylermartin45 moved this from In progress to Blocked in Conda Recipe Manager Oct 8, 2024
@schuylermartin45
Copy link
Collaborator Author

schuylermartin45 commented Oct 21, 2024 •
edited
Loading

From my conversations in the last few weeks, this is still useful. At the very least, we need some more POC material before we can rule it out.
Scratch the previous statement, this tool is probably still useful, but I think it is more important that we parse the data from CF's county fair repo.

@schuylermartin45
Copy link
Collaborator Author

After looking into conda-pypi, I discovered the CF import mapping data was actually publishing to a JSON file that was much easier to parse and utilize.

So this ticket is pivoting to develop a script that can fetch and cache this data to a format that CRM can easily leverage.

@schuylermartin45 schuylermartin45 linked a pull request Oct 25, 2024 that will close this issue
Develop a CRM script to handle import name mis matches #218
Open
@schuylermartin45 schuylermartin45 linked a pull request Oct 25, 2024 that will close this issue
Open
@schuylermartin45 schuylermartin45 moved this from In review to Blocked in Conda Recipe Manager Nov 18, 2024
@schuylermartin45
Copy link
Collaborator Author

This is blocked by either figuring out the licensing details from legal OR by waiting for/build an API in the conda-forge-metadata package. Caching a file derived from the API and comiting it to the repo probably also needs a request from legal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schuylermartin45 schuylermartin45

Labels
enhancement New feature or request source::maintainer to sort Needs additional investigation
Projects
Conda Recipe Manager
Status: Blocked
Milestone
Project: Recipe Bumper
Development

Successfully merging a pull request may close this issue.

Develop a CRM script to handle import name mis matches conda-incubator/conda-recipe-manager
1 participant
@schuylermartin45