Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change attributes to "fields" for JSON API compliance #8

Open
ThorstenSuckow opened this issue Jun 7, 2022 · 1 comment
Open

refactor: change attributes to "fields" for JSON API compliance #8

ThorstenSuckow opened this issue Jun 7, 2022 · 1 comment

Comments

@ThorstenSuckow
Copy link
Member

additionally, change responses and their datastructure. remove "success"-property
@ThorstenSuckow
Copy link
Member Author

ToDo:

  • sparse fieldsets should be considered for "attributes" selection
  • meta objects should contain all data that is not described as standard with the Json API
  • json to jsonApi decorators, or a converter strategy to pass to the entities

ThorstenSuckow added a commit to conjoon/lumen-app-email that referenced this issue Jun 11, 2022
@ThorstenSuckow
refactor: MailAccountController considers json strategy when transfor…
df448dc 
…ming to JSON

refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit that referenced this issue Jun 11, 2022
@ThorstenSuckow
refactor: Jsonable::toJson() can now be run with JsonStrategy
6f8f00d 
refs #8
ThorstenSuckow added a commit to conjoon/lumen-app-email that referenced this issue Jun 11, 2022
@ThorstenSuckow
fix: make sure 401 is returned for GET MailAccounts if client is not …
21118d0 
…aithenticated

refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/extjs-app-webmail that referenced this issue Jun 11, 2022
@ThorstenSuckow
refactor: responses for GET MailAccounts consider updated rest-api-email
68644a3 
refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/extjs-dev-webmailsim that referenced this issue Jun 11, 2022
@ThorstenSuckow
refactor: update MailAccounts to new JSON structure according to rest…
3e90b83 
…-api-email

refs conjoon/php-lib-conjoon#8
ThorstenSuckow pushed a commit that referenced this issue Jun 12, 2022
refactor: transform only first parent into resource linkage
7b4dd58 
refs #8
ThorstenSuckow added a commit to conjoon/rest-api-description that referenced this issue Jun 12, 2022
@ThorstenSuckow
docs: update GET MailFolder to meet json:api specifications with its …
53f9151 
…response

refs conjoon/php-lib-conjoon#8
ThorstenSuckow pushed a commit that referenced this issue Jun 12, 2022
refactor: consider MailFolder child data with json strategy
d0f6094 
refs #8
ThorstenSuckow pushed a commit that referenced this issue Jun 12, 2022
refactor: update MailFolder entity according to updated rest-api-email
aab47d5 
see https://conjoon.org/rest-api/@conjoon/rest-api-description/rest-api-email

refs #8
ThorstenSuckow pushed a commit that referenced this issue Jun 12, 2022
refactor: add Jsonable support for MailFolderChildList
2e9bb79 
refs #8
ThorstenSuckow added a commit that referenced this issue Jun 12, 2022
@ThorstenSuckow
feat: add 401/404 HTTP Status representatives
1da08bb 
refs #8
ThorstenSuckow added a commit to conjoon/lumen-app-email that referenced this issue Jun 12, 2022
@ThorstenSuckow
refactor: MailFolderController considers JsonStrategy with its json r…
251a225 
…esponse

made also sure that Authenticate uses 401/404 Exceptions based on state of authentication
(404 if MailAccount was not found, 401 if authentication failed); removed success property
from response

refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit that referenced this issue Jun 12, 2022
@ThorstenSuckow
feat: the (Http)Problem representative supports Jsonable with JsonStr…
17d8ffe 
…ategy

refs #8
ThorstenSuckow added a commit that referenced this issue Jun 12, 2022
@ThorstenSuckow
refactor: remove makeJson() since its part of the Problem-API
3197499 
refs #8
ThorstenSuckow added a commit that referenced this issue Jun 12, 2022
@ThorstenSuckow
fix: links-object is created although type is set to default about:blank
925507a 
refs #8
ThorstenSuckow added a commit to conjoon/lumen-app-email that referenced this issue Jun 12, 2022
@ThorstenSuckow
refactor: guard now triggers UnauthorizedException if guest request r…
f2c64e2 
…esources

refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/lumen-app-email that referenced this issue Jun 12, 2022
@ThorstenSuckow
feat: make ExceptionHandler consider Problem-Api with Json Strategy
358f1ec 
refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/lumen-app-email that referenced this issue Jun 12, 2022
@ThorstenSuckow
fix(tests): test for 401 ends at guard, not authenticate()
ce36c75 
refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/lumen-app-email that referenced this issue Jun 12, 2022
@ThorstenSuckow
refactor(tests): remove 401 tests for MailAccounts
79ff16b 
only reason at this point a 401 could be returned is if the user is a guest
which is already checked by App\Http\V0\Middleware\Authenticate

refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/lumen-app-email that referenced this issue Jun 12, 2022
@ThorstenSuckow
refactor: namespace updates according to API changes
e8e0f21 
refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/rest-api-description that referenced this issue Jun 12, 2022
@ThorstenSuckow
docs: update documentation with shared responses for errors
d786507 
refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/extjs-app-webmail that referenced this issue Jun 13, 2022
@ThorstenSuckow
refactor: update data structures for GET MailFolders considering upda…
6d9347d 
…ted rest-api-email

refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/extjs-dev-webmailsim that referenced this issue Jun 13, 2022
@ThorstenSuckow
refactor: update MailFolder data structure according to updated rest-…
43c1457 
…api-email

refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/rest-api-description that referenced this issue Jun 16, 2022
@ThorstenSuckow
docs: update errors responses and parameters for GET MessageItems
850c37c 
refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/lumen-app-email that referenced this issue Jun 16, 2022
@ThorstenSuckow
refactor: translator considers updates of rest-api-email
dc0dcef 
refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit that referenced this issue Oct 17, 2022
@ThorstenSuckow
refactor: remove Facade
ff06e9b 
should be part of concrete backend implementation, not library

refs #8
ThorstenSuckow added a commit that referenced this issue Oct 17, 2022
@ThorstenSuckow
refactor: allow to pass arguments to instance created by this factory…
de7ede2 
… method

refs #8
ThorstenSuckow added a commit that referenced this issue Oct 17, 2022
@ThorstenSuckow
refactor: add representsCollection() to determine whether URL represe…
015bc0e 
…nts collection

refs #8
ThorstenSuckow added a commit that referenced this issue Oct 17, 2022
@ThorstenSuckow
refactor: add Url-class for providing access to URL-related attributes
949af9c 
refs #8
ThorstenSuckow added a commit that referenced this issue Oct 17, 2022
@ThorstenSuckow
refactor: update Request implementation for JsonApi
e5f1aa5 
refs #8
ThorstenSuckow added a commit that referenced this issue Oct 18, 2022
@ThorstenSuckow
refactor: remove unnecessary adapters and generalize usage for URL/Re…
cb0c986 
…quest/Query

refs #8
ThorstenSuckow added a commit that referenced this issue Oct 18, 2022
@ThorstenSuckow
refactor: JsonApi/Http uses inheritance instead of Adapters and Decor…
ce1671f 
…ators

refs #8
ThorstenSuckow added a commit that referenced this issue Oct 19, 2022
@ThorstenSuckow
refactor: UrlParser-related implementation considers Url-typed parame…
5b4e3ba 
…ters

refs #8
ThorstenSuckow added a commit that referenced this issue Oct 19, 2022
@ThorstenSuckow
refactor: add targetsResourceCollection() for JsonApiUrl
04b1a37 
returns true if url targets a resource collection

refs #8
ThorstenSuckow added a commit that referenced this issue Oct 19, 2022
@ThorstenSuckow
refactor: MessageItemListQuery must extend ResourceQuery instead of M…
7175a4d 
…essageItemQuery

refs #8
ThorstenSuckow added a commit to conjoon/lumen-app-email that referenced this issue Oct 19, 2022
@ThorstenSuckow
refactor: update bindings with changed API
8543159 
refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/lumen-app-email that referenced this issue Oct 19, 2022
@ThorstenSuckow
refactor: add factory for creating resource queries to pass to low le…
0962331 
…vel api

refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/lumen-app-email that referenced this issue Oct 20, 2022
@ThorstenSuckow
refactor: add JsonApiException extending InternalServerErrorException
8e7d107 
refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit to conjoon/lumen-app-email that referenced this issue Oct 20, 2022
@ThorstenSuckow
refactor: add exception handling and make factory more testable
6cdb89f 
refs conjoon/php-lib-conjoon#8
ThorstenSuckow added a commit that referenced this issue Oct 22, 2022
@ThorstenSuckow
refactor: add Rest/Request/ResourceUrlRegex for mapping urls to url-t…
f2d8d34 
…emplates

refs #8
ThorstenSuckow added a commit that referenced this issue Oct 23, 2022
@ThorstenSuckow
refactor: AbstractList allows only numeric indices
b3cc906 
updated annotations and type hints according to phpstan

refs #8
ThorstenSuckow added a commit that referenced this issue Oct 23, 2022
@ThorstenSuckow
refactor: add ResourceUrlRegexList to maintain collection of Resource…
5683550 
…UrlRegex

updated API from ResourceUrlRegex with naming and Arrayable interface

refs #8
ThorstenSuckow pushed a commit that referenced this issue Oct 25, 2022
refactor: add UriTemplateRegex
2b9933c 
refs #8
ThorstenSuckow pushed a commit that referenced this issue Oct 28, 2022
refactor: add URI representative
8c4704b 
refs #8
ThorstenSuckow pushed a commit that referenced this issue Oct 29, 2022
refactor: update Net package with basic implementations for URL and U…
797e4ae 
…ri template

refs #8
ThorstenSuckow pushed a commit that referenced this issue Oct 30, 2022
refactor: add getPath() to ObjectDescription
8dc3a92 
update according to phpstan and PSR-12

refs #8
ThorstenSuckow pushed a commit that referenced this issue Nov 1, 2022
fix: empty array is considered as no-match
32cf3e7 
add Equatable to Template for comparing two templates for equality

refs #8
ThorstenSuckow pushed a commit that referenced this issue Nov 1, 2022
refactor: add draft for ResourceResolver
6d6f1be 
refs #8
ThorstenSuckow added a commit that referenced this issue Nov 2, 2022
@ThorstenSuckow
Merge pull request #9 from #8
eb77197 
Php lib #8
ThorstenSuckow added a commit that referenced this issue Nov 2, 2022
@ThorstenSuckow
Merge pull request #10 from #8
6fa0737 
Php lib #8
ThorstenSuckow pushed a commit that referenced this issue Nov 2, 2022
Revert "Merge pull request #9 from #8"
2bf91d5 
This reverts commit eb77197, reversing
changes made to 4d9b6f5.
ThorstenSuckow pushed a commit that referenced this issue Nov 9, 2022
Revert "Revert "Merge pull request #9 from #8""
5ef0ef5 
This reverts commit 2bf91d5.
@ThorstenSuckow ThorstenSuckow moved this to In Progress in V2.0 Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
V2.0
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThorstenSuckow