Merge pull request #3934 from apostasie/ci-remove-isolation-hack

Enforce pkg isolation as part of golangci

Author: djdongjin

.github/workflows/project.yml

@@ -30,5 +30,3 @@ jobs:
           repo-access-token: ${{ secrets.GITHUB_TOKEN }}
       - run: ./hack/verify-no-patent.sh
         working-directory: src/github.com/containerd/nerdctl
-      - run: ./hack/verify-pkg-isolation.sh
-        working-directory: src/github.com/containerd/nerdctl

.golangci.yml

@@ -5,7 +5,7 @@ run:
 linters:
   disable-all: true
   enable:
-    # - depguard
+    - depguard
     - gofmt
     - goimports
     - govet
@@ -135,6 +135,22 @@ linters-settings:
       - unnamedResult
       - unnecessaryBlock
 
+  depguard:
+    rules:
+      # pkg files must not depend on cobra nor anything in cmd
+      pkg:
+        files:
+          - "**/pkg/**/*.go"
+        deny:
+          - pkg: "github.com/spf13/cobra"
+            desc: "pkg must not depend on cobra"
+          - pkg: "github.com/spf13/pflag"
+            desc: "pkg must not depend on pflag"
+          - pkg: "github.com/spf13/viper"
+            desc: "pkg must not depend on viper"
+          - pkg: "github.com/containerd/nerdctl/v2/cmd"
+            desc: "pkg must not depend on any cmd files"
+
 issues:
   max-issues-per-linter: 0
   max-same-issues: 0