Invalid usage of `Validate` function in `ssh.golangConnectionDial` is causing connection issues to remote podman

[gkapkowski]

It looks like Validate function requires a path to be passed as a second argument:

func Validate(user *url.Userinfo, path string, port int, identity string) (*config.Destination, *url.URL, error) {
	// url.Parse NEEDS ssh://, if this ever fails or returns some nonsense, that is why.
	uri, err := url.Parse(path)
	if err != nil {
		return nil, nil, err
	}

https://github.com/containers/common/blob/main/pkg/ssh/utils.go#L21

BUT in golangConnectionDial https://github.com/containers/common/blob/main/pkg/ssh/connection_golang.go#L92

The invocation passes options.Host (which at this point is simply an IP "x.x.x.x")

func golangConnectionDial(options ConnectionDialOptions) (*ConnectionDialReport, error) {
	_, uri, err := Validate(options.User, options.Host, options.Port, options.Identity)
	if err != nil {
		return nil, err
	}

This caused the uri.Host and uri.Path values to be invalid

[gkapkowski]

Changing the invocation to Validate(options.User, "ssh://"+options.Host, options.Port, options.Identity) fixes the connection problem. (but that's not how this should be fixed , I think)

Before:

INFO[0000] /Users/grzegorz/Workspace/podman/cmd/podman/__debug_bin1910660116 filtering at log level trace 
DEBU[0000] Called ps.PersistentPreRunE(/Users/grzegorz/Workspace/podman/cmd/podman/__debug_bin1910660116 --log-level=trace ps) 
DEBU[0000] ssh_config alias found: 10.0.0.27            
DEBU[0000]   User: grzegorz                             
DEBU[0000]   Hostname: 10.0.0.27                        
DEBU[0000]   Port: 22                                   
DEBU[0000]   IdentityFile: "/Users/grzegorz/.ssh/id_ed25519" 
DEBU[0004] SSH Ident Key "/Users/grzegorz/.ssh/id_ed25519" 
Cannot connect to Podman. Please verify your connection to the Linux system using `podman system connection list`, or try `podman machine init` and `podman machine start` to manage a new Linux VM
Error: unable to connect to Podman socket: failed to connect: dial tcp :22: connect: connection refused
DEBU[0004] Shutting down engines                        
Exiting.

After:

INFO[0000] /Users/grzegorz/Workspace/podman/cmd/podman/__debug_bin4092351555 filtering at log level trace 
DEBU[0000] Called ps.PersistentPreRunE(/Users/grzegorz/Workspace/podman/cmd/podman/__debug_bin4092351555 --log-level=trace ps) 
DEBU[0000] ssh_config alias found: 10.0.0.27            
DEBU[0000]   User: grzegorz                             
DEBU[0000]   Hostname: 10.0.0.27                        
DEBU[0000]   Port: 22                                   
DEBU[0000]   IdentityFile: "/Users/grzegorz/.ssh/id_ed25519" 
DEBU[0005] SSH Ident Key "/Users/grzegorz/.ssh/id_ed25519" 
DEBU[0005] DoRequest Method: GET URI: http://d/v5.6.0/libpod/_ping 
DEBU[0010] DoRequest Method: GET URI: http://d/v5.6.0/libpod/containers/json 
CONTAINER ID  IMAGE                            COMMAND     CREATED       STATUS       PORTS       NAMES
b2ed7a424fc5  docker.io/library/ubuntu:latest  /bin/bash   14 hours ago  Up 14 hours              unruffled_nightingale
DEBU[0010] Called ps.PersistentPostRunE(/Users/grzegorz/Workspace/podman/cmd/podman/__debug_bin4092351555 --log-level=trace ps) 
DEBU[0010] Shutting down engines                        
Exiting.