Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create tag pkg/topology/v0.1.0 #94

Open
mythi opened this issue Jul 17, 2023 · 5 comments
Open

create tag pkg/topology/v0.1.0 #94

mythi opened this issue Jul 17, 2023 · 5 comments

Comments

@mythi
Copy link
Contributor

mythi commented Jul 17, 2023

It's not possible to use v0.1.0 tag for pkg/topology:

If a module is defined in a subdirectory within the repository, that is, the module subdirectory portion of the module path is not empty, then each tag name must be prefixed with the module subdirectory, followed by a slash. For example, the module golang.org/x/tools/gopls is defined in the gopls subdirectory of the repository with root path golang.org/x/tools. The version v0.4.0 of that module must have the tag named gopls/v0.4.0 in that repository.

https://go.dev/ref/mod#vcs-version

@marquiz
Copy link
Collaborator

marquiz commented Jul 25, 2023

What would you want this for? Do we really want to start serving different packages as separately served go modules? I wouldn't

@mythi
Copy link
Contributor Author

mythi commented Jul 25, 2023

We have had pkg/topology maintained in two places and now this repo could serve the proper upstream for downstream users too intel/intel-device-plugins-for-kubernetes#1379

@mythi
Copy link
Contributor Author

mythi commented Jul 25, 2023

Do we really want to start serving different packages as separately served go modules?

it's also not a new ask but pkg/topology has been served long time already.

@mythi
Copy link
Contributor Author

mythi commented Aug 1, 2023

WDYT? This mostly complements the existing v0.1.0 tag.

@mythi
Copy link
Contributor Author

mythi commented Sep 5, 2023

WDYT? This mostly complements the existing v0.1.0 tag.

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants