-
Notifications
You must be signed in to change notification settings - Fork 33
WIP: Add TMT gating test and workflow for bootupd #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @aaradhak, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request establishes a new, robust testing infrastructure for the bootupd
project by integrating the Test Management Tool (TMT). It introduces a fundamental smoke test to confirm bootupd
package installation and sets up a flexible test environment capable of handling bootupd
binaries from either source builds or installed packages. This initiative significantly enhances the project's automated testing capabilities.
Highlights
- TMT Test Infrastructure: Introduces the Test Management Tool (TMT) framework to the project, laying the foundation for automated testing.
- Core Smoke Test: Adds a basic smoke test (
tests/core/core.fmf
) to verify the successful installation of thebootupd
package. - Flexible Test Environment Setup: Implements conditional
prepare
steps intests/tmt/plans/main.fmf
to support testingbootupd
whether it's built from source or installed as a distribution package. - TMT Smoke Plan: Defines a TMT plan (
tests/tmt/plans/smoke.fmf
) to discover and execute all tests tagged with 'smoke'.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces TMT testing infrastructure for bootupd
, including a core smoke test and a GitHub workflow. The changes are well-structured. I've found a couple of issues in the test preparation scripts: one related to the robustness of finding the bootupd
binary when built from source, and a critical issue with an incorrect hardcoded path for the package-installed binary. Addressing these will improve the reliability of the new test suite.
Add TMT testing infrastructure including core smoke test with GitHub workflow integration.
130b694
to
3d1b4c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to this but it's also important to acknowledge that this is testing almost nothing.
As far as I understand without additional work, it will not be testing the source changes to the git repository here, only installing the existing package, which seems misleading at best.
I think what actually is solving that problem is packit which acts as a glue later on top of testing-farm/tmt to build rpms in a copr and then inject them by default.
But that gets to the next problem that doing useful bootupd testing requires being in a bootc/coreos system so we'd need to use e.g. https://tmt.readthedocs.io/en/1.42/plugins/provision.html#bootc
# the distribution package or when it is built from source in the test environment | ||
prepare: | ||
- name: Set BOOTUPD_BIN_DIR when built from source | ||
when: use_built_from_src is defined and use_built_from_src == true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What defines use_built_from_src
?
Add TMT testing infrastructure including core smoke test with GitHub workflow integration.