Skip to content

Commit f9f9c5b

Browse files
committed
osbuild: go back to setting metadata_csum_seed=true
Here we just unconditionally set it because otherwise changing the filesystem while it is mounted doesn't work and we get errors like this during startup: ``` [ 4.155947] ignition-ostree-firstboot-uuid[918]: /dev/disk/by-label/boot is in use. ``` Anyways, we are going to delete the fallback code there anyway coreos/fedora-coreos-config#3008 so it's required to be set so let's set it here and then we can drop this once RHEL has caught up.
1 parent 3a1e293 commit f9f9c5b

File tree

4 files changed

+40
-0
lines changed

4 files changed

+40
-0
lines changed

src/osbuild-manifests/coreos.osbuild.aarch64.mpp.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,11 @@ pipelines:
290290
mpp-format-string: '{boot_fs_uuid}'
291291
label:
292292
mpp-format-string: '{boot_fs_label}'
293+
# Set manually the metadata_csum_seed ext4 option otherwise changing the
294+
# filesystem UUID while it's mounted doesn't work. Can remove this when
295+
# metadata_csum_seed is default in RHEL, which can be checked by looking
296+
# in /etc/mke2fs.conf.
297+
metadata_csum_seed: true
293298
- type: org.osbuild.mkfs.xfs
294299
devices:
295300
device:
@@ -449,6 +454,11 @@ pipelines:
449454
mpp-format-string: '{boot_fs_uuid}'
450455
label:
451456
mpp-format-string: '{boot_fs_label}'
457+
# Set manually the metadata_csum_seed ext4 option otherwise changing the
458+
# filesystem UUID while it's mounted doesn't work. Can remove this when
459+
# metadata_csum_seed is default in RHEL, which can be checked by looking
460+
# in /etc/mke2fs.conf.
461+
metadata_csum_seed: true
452462
- type: org.osbuild.mkfs.xfs
453463
devices:
454464
device:

src/osbuild-manifests/coreos.osbuild.ppc64le.mpp.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,11 @@ pipelines:
283283
mpp-format-string: '{boot_fs_uuid}'
284284
label:
285285
mpp-format-string: '{boot_fs_label}'
286+
# Set manually the metadata_csum_seed ext4 option otherwise changing the
287+
# filesystem UUID while it's mounted doesn't work. Can remove this when
288+
# metadata_csum_seed is default in RHEL, which can be checked by looking
289+
# in /etc/mke2fs.conf.
290+
metadata_csum_seed: true
286291
- type: org.osbuild.mkfs.xfs
287292
devices:
288293
device:
@@ -419,6 +424,11 @@ pipelines:
419424
mpp-format-string: '{boot_fs_uuid}'
420425
label:
421426
mpp-format-string: '{boot_fs_label}'
427+
# Set manually the metadata_csum_seed ext4 option otherwise changing the
428+
# filesystem UUID while it's mounted doesn't work. Can remove this when
429+
# metadata_csum_seed is default in RHEL, which can be checked by looking
430+
# in /etc/mke2fs.conf.
431+
metadata_csum_seed: true
422432
- type: org.osbuild.mkfs.xfs
423433
devices:
424434
device:

src/osbuild-manifests/coreos.osbuild.s390x.mpp.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,11 @@ pipelines:
282282
mpp-format-string: '{boot_fs_uuid}'
283283
label:
284284
mpp-format-string: '{boot_fs_label}'
285+
# Set manually the metadata_csum_seed ext4 option otherwise changing the
286+
# filesystem UUID while it's mounted doesn't work. Can remove this when
287+
# metadata_csum_seed is default in RHEL, which can be checked by looking
288+
# in /etc/mke2fs.conf.
289+
metadata_csum_seed: true
285290
- type: org.osbuild.mkfs.xfs
286291
devices:
287292
device:
@@ -389,6 +394,11 @@ pipelines:
389394
mpp-format-string: '{boot_fs_uuid}'
390395
label:
391396
mpp-format-string: '{boot_fs_label}'
397+
# Set manually the metadata_csum_seed ext4 option otherwise changing the
398+
# filesystem UUID while it's mounted doesn't work. Can remove this when
399+
# metadata_csum_seed is default in RHEL, which can be checked by looking
400+
# in /etc/mke2fs.conf.
401+
metadata_csum_seed: true
392402
- type: org.osbuild.mkfs.xfs
393403
devices:
394404
device:

src/osbuild-manifests/coreos.osbuild.x86_64.mpp.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,11 @@ pipelines:
292292
mpp-format-string: '{boot_fs_uuid}'
293293
label:
294294
mpp-format-string: '{boot_fs_label}'
295+
# Set manually the metadata_csum_seed ext4 option otherwise changing the
296+
# filesystem UUID while it's mounted doesn't work. Can remove this when
297+
# metadata_csum_seed is default in RHEL, which can be checked by looking
298+
# in /etc/mke2fs.conf.
299+
metadata_csum_seed: true
295300
- type: org.osbuild.mkfs.xfs
296301
devices:
297302
device:
@@ -453,6 +458,11 @@ pipelines:
453458
mpp-format-string: '{boot_fs_uuid}'
454459
label:
455460
mpp-format-string: '{boot_fs_label}'
461+
# Set manually the metadata_csum_seed ext4 option otherwise changing the
462+
# filesystem UUID while it's mounted doesn't work. Can remove this when
463+
# metadata_csum_seed is default in RHEL, which can be checked by looking
464+
# in /etc/mke2fs.conf.
465+
metadata_csum_seed: true
456466
- type: org.osbuild.mkfs.xfs
457467
devices:
458468
device:

0 commit comments

Comments
 (0)