vars/kola: deprecate --basic-qemu-scenarios, --skipSecureBoot

The argument for --basic-qemu-scenarios, and --skipSecureBoot have been deprecated.
Depending on the version of cosa, the tests that would be skipped by these args are
now formal kola tests. And to skip them you can use --denylist-test commands.

skipSecureBoot now translates to  --denylist-test
*.uefi-secure

Author: prestist

vars/kola.groovy

@@ -7,8 +7,8 @@
 //    arch:               string   -- the target architecture
 //    cosaDir:            string   -- cosa working directory
 //    parallel:           integer  -- number of tests to run in parallel (default: # CPUs)
-//    skipBasicScenarios  boolean  -- skip basic qemu scenarios
-//    skipSecureBoot      boolean  -- skip secureboot tests
+//    skipBasicScenarios  boolean  -- skip basic qemu scenarios, as of cosa v0.17.0 these tests are part of kola. consquently this option is deprecated
+//    skipSecureBoot      boolean  -- skip secureboot tests, as of cosa v0.17.0 these tests are part of kola. consquently this option is deprecated
 //    skipUpgrade:        boolean  -- skip running `cosa kola --upgrades`
 //    build:              string   -- cosa build ID to target
 //    platformArgs:       string   -- platform-specific kola args (e.g. '-p aws --aws-ami ...`)
@@ -117,12 +117,19 @@ def call(params = [:]) {
             runKola(id, 'run', "--parallel=${parallel} ${args} ${extraArgs}")
         } else {
             // basic run
-            if (!params['skipBasicScenarios']) {
+            // Check if kola has old or new basic scenarios
+            def out = shwrapCapture("""
+            cd ${cosaDir}
+            cosa kola list
+        """)
+            def newBasic.nvmeExist = out.readLines().any { it =~ /basic\.nvme/ }
+
+            if (!params['skipBasicScenarios'] && !exists) {
                 id = marker == "" ? "kola-basic" : "kola-basic-${marker}"
                 ids += id
                 def skipSecureBootArg = ""
-                if (params['skipSecureBoot']) {
-                    skipSecureBootArg = "--skip-secure-boot"
+            if (params['skipSecureBoot'] && !exists) {
+                skipSecureBootArg = "--skip-secure-boot"
                 }
                 runKola(id, 'run', "--basic-qemu-scenarios ${skipSecureBootArg}")
             }