Skip to content

Fix test failures while upgrading to latest JUnit #478

@chockalingamc

Description

@chockalingamc

Recently, while upgrading dependencies for ACCP, the JUnit dependency could only be bumped up to v5.10.3.

From Junit 5.10.4, a new feature related to parallel execution and global read-write lock causes RemoveDefaultProvidersTest to fail.
https://docs.junit.org/5.10.4/release-notes/#new-features-and-improvements

Improve parallelism and reduce number of blocked threads used by HierarchicalTestEngine implementations when parallel execution is enabled and the global read-write lock is used.

JUnit 5.10.5 seems to have a bugfix related to test failures resulting from the above feature from 5.10.4
https://docs.junit.org/5.10.5/release-notes/#release-notes-5.10.5-junit-platform-bug-fixes

Fix regression in parallel execution that was introduced in 5.10.4 regarding global read-write locks. When such a lock was declared on descendants of top-level nodes in the test tree, such as Cucumber scenarios, test execution failed.

But that doesn't seem to fix the RemoveDefaultProvidersTest test failure in ACCP.

The RemoveDefaultProvidersTest uses global read/write lock to force isolated execution.

This test, while getting an instance of ACCP, goes through FIPS status check of underlying libcrypto. These tests are expected to have completed by the time ACCP is instantiated. But it looks like the change in JUnit has altered the execution such that the FIPS check times out.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions