add dynamic gasfee pricing as a signing client option - Feemarket/Osmosis #1911

ertemann · 2025-11-18T14:42:32Z

Summary

Adds automatic gas price discovery for chains with dynamic feemarket modules (Osmosis EIP-1559 and Skip feemarket). Instead of manually setting static gas prices, CosmJS can now query current prices from the chain, preventing transaction failures from outdated pricing.

Changes

New feemarket.ts: Query dynamic gas prices from Osmosis EIP-1559 and Skip feemarket modules
Updated clients: SigningStargateClient and SigningCosmWasmClient now support DynamicGasPriceConfig
Refactoring: Extracted calculateFeeForTransaction() helper
Tests: Some unit tests and an end-to-end validation on Osmosis and Neutron testnets

Usage

const client = await SigningStargateClient.connectWithSigner(rpc, signer, {
  gasPrice: {
    denom: "uosmo",
    multiplier: 1.3,
    minGasPrice: GasPrice.fromString("0.0025uosmo"),
    maxGasPrice: GasPrice.fromString("0.1uosmo"),
  }
});

// Gas price queried automatically per transaction
await client.signAndBroadcast(address, messages, "auto");

Features

Graceful fallback to minGasPrice if feemarket query fails
Min/max constraint enforcement with configurable multiplier
backward compatible - existing code unchanged
Automatic chain detection for Osmosis variants

Inspired by Hermes relayer PR #4004.

… eip1559

ertemann · 2025-11-18T14:53:41Z

packages/stargate/src/signingstargateclient.ts

+
+        // Multiply by multiplier 18 fractional digits for Dec type
+        const fractionalDigits = minGasPrice.amount.fractionalDigits;
+        const adjustedGasPrice = multiplyDecimalByNumber(


If there is a cleaner way to do this please advise

ertemann · 2025-11-18T14:54:27Z

packages/stargate/src/test-feemarket-multichain.mjs

+
+// Replace with your mnemonic or set MNEMONIC env var
+// WARNING: Never commit real mnemonics to git!
+const MNEMONIC =


throwaway mnemonic for you to test with.

ertemann · 2025-11-18T14:54:53Z

packages/stargate/src/test-feemarket-multichain.mjs

@@ -0,0 +1,278 @@
+#!/usr/bin/env node


Just a complete integration test to validate the PR, can be removed once merged

ertemann · 2025-11-18T20:13:19Z

packages/stargate/src/feemarket.ts

+  }
+}
+
+// Minimal protobuf type definitions matching cosmjs-types pattern


or should this actually go into cosmjs/types? they refer to /feemarket module ofcourse and not base SDK

I think it's good enough as is and can be refactored later on

webmaster128

Nice stuff. Some first thoughts here

webmaster128 · 2025-11-22T18:34:15Z

packages/cosmwasm/src/signingcosmwasmclient.ts

  // E.g. https://github.com/cosmos/cosmos-sdk/issues/16020
  private readonly defaultGasMultiplier = 1.4;
+  // Default multiplier for dynamic gas price (applied on top of queried price)
+  private readonly defaultDynamicGasMultiplier = 1.3;


This is a gas price multiplier, not a gas multiplier, right? I think it is important to highlight this e.g. by renaming

Suggested change

private readonly defaultDynamicGasMultiplier = 1.3;

private readonly defaultDynamicGasPriceMultiplier = 1.3;

you are right, oversight by me.

can we make it dynamicGasFeeMultiplier though seeing as it considers the fee portion of the total gasprice configuration ?

A "fee" in Cosmos SDK contains the gas (gas limit) a transaction can use as well as the amount of Coins paid. This the price per gas can be calculated from that. So there is everything mixed together.

What we do here is having two data sources for the components of the fee:

Tha gas (gas limit) is calculated through simulation

The gas price is either configured or queried from chain starting with this PR

The multiplier here only affects 2. and not 1.

I.e. we do not multiply the fee (gas limit remains unchanged, granter and payer cannot be multiplied) but the gas price.

webmaster128 · 2025-11-22T18:50:05Z

packages/cosmwasm/src/signingcosmwasmclient.ts

+    fee: "auto" | number,
+  ): Promise<StdFee> {
+    const gasEstimation = await this.simulate(signerAddress, messages, memo);
+    const multiplier = typeof fee === "number" ? fee : this.defaultGasMultiplier;


At this point we know the gas limit, right? Everything else below is just about the price.

Adding

const gasLimit = Math.ceil(gasEstimation * multiplier)

here would remove the 4x Math.round(gasEstimation * multiplier) from below and increase readability.

webmaster128 · 2025-11-22T19:03:59Z

packages/stargate/src/feemarket.ts

+  const product = (BigInt(normalizedValue.atomics) * BigInt(multiplierDecimal.atomics)) / factor;
+
+  return Decimal.fromAtomics(product.toString(), fractionalDigits);
+}


This implementation might be correct. But as we do not need decimal math here we can also use float math more or less like this:

const x = value.toFloatApproximation() * multiplier; // the value we want // now convert x to Decimal

Now exactly as the Decimal API is limited but I think you get the idea

webmaster128 · 2025-11-22T19:05:17Z

packages/stargate/src/feemarket.ts

+  const normalizedValue =
+    value.fractionalDigits === fractionalDigits
+      ? value
+      : Decimal.fromUserInput(value.toString(), fractionalDigits);


This part is something the class Decimal should have. I.e. convert decimal "2.0" to "2.000" by changing the number of decimals from 1 to 3

See #1916 which will give you an API for that

webmaster128 · 2025-11-22T19:08:46Z

packages/stargate/src/feemarket.ts

+  }
+}
+
+// Minimal protobuf type definitions matching cosmjs-types pattern


I think it's good enough as is and can be refactored later on

packages/stargate/src/feemarket.spec.ts

+import { Decimal } from "@cosmjs/math";
+import { fromUtf8 } from "@cosmjs/encoding";
+
+import { GasPrice } from "./fee";


packages/stargate/src/feemarket.spec.ts

+      const response = new Uint8Array([
+        10, 17, 51, 48, 48, 48, 48, 48, 48, 48, 48, 48, 48, 48, 48, 48, 48, 48, 48,
+      ]);
+      const queryClient = createMockQueryClient(response);


packages/stargate/src/feemarket.spec.ts

+        10, 25, 10, 5, 117, 97, 116, 111, 109, 18, 16, 53, 51, 48, 48, 48, 48, 48, 48, 48, 48, 48, 48, 48, 48,
+        48, 48,
+      ]);
+      const queryClient = createMockQueryClient(response);


ertemann · 2025-11-28T13:21:29Z

Thanks for the comments @webmaster128 will resolve remaining issues tomorrow, didnt have time this week yet.

add dynamic gasfee pricing as an option through feemarket and osmosis…

fe524db

… eip1559

ertemann changed the title ~~add dynamic gasfee pricing as an option through feemarket and osmosis…~~ add dynamic gasfee pricing as a signing client option - Feemarket/Osmosis Nov 18, 2025

ertemann commented Nov 18, 2025

View reviewed changes

ertemann marked this pull request as draft November 18, 2025 15:00

ertemann marked this pull request as ready for review November 18, 2025 20:10

move to proto cosmjs/types style queries/decoding

713f6bb

ertemann force-pushed the add-feemarket-auto branch from 45ed0de to 713f6bb Compare November 18, 2025 20:12

ertemann commented Nov 18, 2025

View reviewed changes

[autofix.ci] apply automated fixes

d023f11

webmaster128 reviewed Nov 22, 2025

View reviewed changes

github-advanced-security bot found potential problems Nov 22, 2025

View reviewed changes

	private readonly defaultDynamicGasMultiplier = 1.3;
	private readonly defaultDynamicGasPriceMultiplier = 1.3;

add dynamic gasfee pricing as a signing client option - Feemarket/Osmosis #1911

Are you sure you want to change the base?

add dynamic gasfee pricing as a signing client option - Feemarket/Osmosis #1911

Uh oh!

Conversation

ertemann commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Features

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webmaster128 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Check notice

Check notice

Check notice

ertemann commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ertemann commented Nov 18, 2025 •

edited

Loading