Merge branch 'main' into chore/deprecate-nft

Author: aljo242

RELEASE_NOTES.md

@@ -1,16 +1,17 @@
-# Cosmos SDK v0.50.12 Release Notes
+# Cosmos SDK v0.53.0 Release Notes
 
 💬 [**Release Discussion**](https://github.com/orgs/cosmos/discussions/58)
 
 ## 🚀 Highlights
 
-This patch release fixes [GHSA-x5vx-95h7-rv4p](https://github.com/cosmos/cosmos-sdk/security/advisories/GHSA-x5vx-95h7-rv4p).
-It resolves a `x/group` module issue that can halt chain when handling a malicious proposal.
-Only users of the `x/group` module are affected by this issue.
+Announcing Cosmos SDK v0.53
 
-We recommended to upgrade to this patch release as soon as possible.
-When upgrading from <= v0.50.11, please use a chain upgrade to ensure that 2/3 of the validator power upgrade to v0.50.12.
+We are pleased to announce the release of Cosmos SDK v0.53! We’re excited to be delivering a new version of the Cosmos SDK that provides key features and updates while minimizing breaking changes so you can focus on what matters most: building.
+
+Upgrading to this verison of the Cosmos SDK from any `v0.50.x` release will **require a coordinated chain upgrade**.
+
+For more upgrade information, check out our [upgrading guide](https://github.com/cosmos/cosmos-sdk/blob/v0.53.0/UPGRADING.md)
 
 ## 📝 Changelog
 
-Check out the [changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.50.12/CHANGELOG.md) for an exhaustive list of changes, or [compare changes](https://github.com/cosmos/cosmos-sdk/compare/v0.50.11...v0.50.12) from the last release.
+Check out the [changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.53.0/CHANGELOG.md) for an exhaustive list of changes, or [compare changes](https://github.com/cosmos/cosmos-sdk/compare/v0.50.12...v0.53.0) from the last release.

UPGRADE_GUIDE.md

@@ -406,36 +406,56 @@ Lastly, add an entry for epochs in the ModuleConfig:
 
 ## Enable Unordered Transactions **OPTIONAL**
 
-To enable unordered transaction support on an application, the ante handler options must be updated.
+To enable unordered transaction support on an application, the `x/auth` keeper must be supplied with the `WithUnorderedTransactions` option.
+
+Note that unordered transactions require sequence values to be zero, and will **FAIL** if a non-zero sequence value is set.
+Please ensure no sequence value is set when submitting an unordered transaction.
+Services that rely on prior assumptions about sequence values should be updated to handle unordered transactions.
+Services should be aware that when the transaction is unordered, the transaction sequence will always be zero.
+
+```go
+	app.AccountKeeper = authkeeper.NewAccountKeeper(
+		appCodec,
+		runtime.NewKVStoreService(keys[authtypes.StoreKey]),
+		authtypes.ProtoBaseAccount,
+		maccPerms,
+		authcodec.NewBech32Codec(sdk.Bech32MainPrefix),
+		sdk.Bech32MainPrefix,
+		authtypes.NewModuleAddress(govtypes.ModuleName).String(),
+		authkeeper.WithUnorderedTransactions(true), // new option!
+	)
+```
+
+If using dependency injection, update the auth module config.
+
+```go
+		{
+			Name: authtypes.ModuleName,
+			Config: appconfig.WrapAny(&authmodulev1.Module{
+				Bech32Prefix:             "cosmos",
+				ModuleAccountPermissions: moduleAccPerms,
+				EnableUnorderedTransactions: true, // remove this line if you do not want unordered transactions.
+			}),
+		},
+```
+
+By default, unordered transactions use a transaction timeout duration of 10 minutes and a default gas charge of 2240 gas units.
+To modify these default values, pass in the corresponding options to the new `SigVerifyOptions` field in `x/auth's` `ante.HandlerOptions`.
 
 ```go
 options := ante.HandlerOptions{
-    // ...
-    UnorderedNonceManager: app.AccountKeeper,
-    // The following options are set by default.
-    // If you do not want to change these, you may remove the UnorderedTxOptions field entirely.
-    UnorderedTxOptions: []ante.UnorderedTxDecoratorOptions{
-        ante.WithUnorderedTxGasCost(2240),
-        ante.WithTimeoutDuration(10 * time.Minute),
+    SigVerifyOptions: []ante.SigVerificationDecoratorOption{
+        // change below as needed.
+        ante.WithUnorderedTxGasCost(ante.DefaultUnorderedTxGasCost),
+        ante.WithMaxUnorderedTxTimeoutDuration(ante.DefaultMaxTimoutDuration),
     },
 }
+```
 
+```go
 anteDecorators := []sdk.AnteDecorator{
-    ante.NewSetUpContextDecorator(), // outermost AnteDecorator. SetUpContext must be called first
-    circuitante.NewCircuitBreakerDecorator(options.CircuitKeeper),
-    ante.NewExtensionOptionsDecorator(options.ExtensionOptionChecker),
-    ante.NewValidateBasicDecorator(),
-    ante.NewTxTimeoutHeightDecorator(),
-    ante.NewValidateMemoDecorator(options.AccountKeeper),
-    ante.NewConsumeGasForTxSizeDecorator(options.AccountKeeper),
-    ante.NewDeductFeeDecorator(options.AccountKeeper, options.BankKeeper, options.FeegrantKeeper, options.TxFeeChecker),
-    ante.NewSetPubKeyDecorator(options.AccountKeeper), // SetPubKeyDecorator must be called before all signature verification decorators
-    ante.NewValidateSigCountDecorator(options.AccountKeeper),
-    ante.NewSigGasConsumeDecorator(options.AccountKeeper, options.SigGasConsumer),
-    ante.NewSigVerificationDecorator(options.AccountKeeper, options.SignModeHandler),
-    ante.NewIncrementSequenceDecorator(options.AccountKeeper),
-    // NEW !! NEW !! NEW !!
-    ante.NewUnorderedTxDecorator(options.UnorderedNonceManager, options.UnorderedTxOptions...)
+	// ... other decorators ...
+    ante.NewSigVerificationDecorator(options.AccountKeeper, options.SignModeHandler, options.SigVerifyOptions...), // supply new options
 }
 ```
 

UPGRADING.md

@@ -25,42 +25,58 @@ To submit an unordered transaction, clients must set the `unordered` flag to
 used as a TTL for the transaction and provides replay protection. Each transaction's `timeout_timestamp` must be
 unique to the account; however, the difference may be as small as a nanosecond. See [ADR-070](https://github.com/cosmos/cosmos-sdk/blob/main/docs/architecture/adr-070-unordered-transactions.md) for more details.
 
+Note that unordered transactions require sequence values to be zero, and will **FAIL** if a non-zero sequence value is set. 
+Please ensure no sequence value is set when submitting an unordered transaction.
+Services that rely on prior assumptions about sequence values should be updated to handle unordered transactions.
+Services should be aware that when the transaction is unordered, the transaction sequence will always be zero.
+
 #### Enabling Unordered Transactions
 
-To enable unordered transactions, set the new `UnorderedNonceManager` field in the `x/auth` `ante.HandlerOptions`.
+To enable unordered transactions, supply the `WithUnorderedTransactions` option to the `x/auth` keeper:
+
+```go
+	app.AccountKeeper = authkeeper.NewAccountKeeper(
+		appCodec,
+		runtime.NewKVStoreService(keys[authtypes.StoreKey]),
+		authtypes.ProtoBaseAccount,
+		maccPerms,
+		authcodec.NewBech32Codec(sdk.Bech32MainPrefix),
+		sdk.Bech32MainPrefix,
+		authtypes.NewModuleAddress(govtypes.ModuleName).String(),
+		authkeeper.WithUnorderedTransactions(true), // new option!
+	)
+```
+
+If using dependency injection, update the auth module config.
+
+```go
+		{
+			Name: authtypes.ModuleName,
+			Config: appconfig.WrapAny(&authmodulev1.Module{
+				Bech32Prefix:             "cosmos",
+				ModuleAccountPermissions: moduleAccPerms,
+				EnableUnorderedTransactions: true, // remove this line if you do not want unordered transactions.
+			}),
+		},
+```
 
-By default, unordered transactions use a transaction timeout duration of 10 minutes and a default gas charge of 2240 gas.
-To modify these default values, pass in the corresponding options to the new `UnorderedTxOptions` field in `x/auth's` `ante.HandlerOptions`.
+By default, unordered transactions use a transaction timeout duration of 10 minutes and a default gas charge of 2240 gas units.
+To modify these default values, pass in the corresponding options to the new `SigVerifyOptions` field in `x/auth's` `ante.HandlerOptions`.
 
 ```go
 options := ante.HandlerOptions{
-    UnorderedNonceManager: app.AccountKeeper,
-	// The following options are set by default.
-	// If you do not want to change these, you may remove the UnorderedTxOptions field entirely.
-    UnorderedTxOptions: []ante.UnorderedTxDecoratorOptions{
-        ante.WithUnorderedTxGasCost(2240),
-        ante.WithTimeoutDuration(10 * time.Minute),
+    SigVerifyOptions: []ante.SigVerificationDecoratorOption{
+        // change below as needed.
+        ante.WithUnorderedTxGasCost(ante.DefaultUnorderedTxGasCost),
+        ante.WithMaxUnorderedTxTimeoutDuration(ante.DefaultMaxTimoutDuration),
     },
 }
 ```
 
 ```go
 anteDecorators := []sdk.AnteDecorator{
-  ante.NewSetUpContextDecorator(), // outermost AnteDecorator. SetUpContext must be called first
-  circuitante.NewCircuitBreakerDecorator(options.CircuitKeeper),
-  ante.NewExtensionOptionsDecorator(options.ExtensionOptionChecker),
-  ante.NewValidateBasicDecorator(),
-  ante.NewTxTimeoutHeightDecorator(),
-  ante.NewValidateMemoDecorator(options.AccountKeeper),
-  ante.NewConsumeGasForTxSizeDecorator(options.AccountKeeper),
-  ante.NewDeductFeeDecorator(options.AccountKeeper, options.BankKeeper, options.FeegrantKeeper, options.TxFeeChecker),
-  ante.NewSetPubKeyDecorator(options.AccountKeeper), // SetPubKeyDecorator must be called before all signature verification decorators
-  ante.NewValidateSigCountDecorator(options.AccountKeeper),
-  ante.NewSigGasConsumeDecorator(options.AccountKeeper, options.SigGasConsumer),
-  ante.NewSigVerificationDecorator(options.AccountKeeper, options.SignModeHandler),
-  ante.NewIncrementSequenceDecorator(options.AccountKeeper),
-  // NEW !! NEW !! NEW !!
-  ante.NewUnorderedTxDecorator(options.UnorderedNonceManager, options.UnorderedTxOptions...)
+    // ... other decorators ...
+    ante.NewSigVerificationDecorator(options.AccountKeeper, options.SignModeHandler, options.SigVerifyOptions...), // supply new options
 }
 ```