chore: deprecate nft for future (#24575)

aljo242 · web-flow · commit 9168ce46d7a8 · 2025-04-29T13:51:01.000Z
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -36,6 +36,10 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 # Changelog
 
+### Deprecated
+
+* (x/nft) [#24575](https://github.com/cosmos/cosmos-sdk/pull/24575) Deprecate the `x/nft` module in the Cosmos SDK repository.  This module will not be maintained to the extent that our core modules will and will be kept in a [legacy repo](https://github.com/cosmos/cosmos-legacy).
+
 ## [Unreleased]
 
 ### Deprecated
diff --git a/simapp/app.go b/simapp/app.go
@@ -29,9 +29,9 @@ import (
 	"cosmossdk.io/x/feegrant"
 	feegrantkeeper "cosmossdk.io/x/feegrant/keeper"
 	feegrantmodule "cosmossdk.io/x/feegrant/module"
-	"cosmossdk.io/x/nft"
-	nftkeeper "cosmossdk.io/x/nft/keeper"
-	nftmodule "cosmossdk.io/x/nft/module"
+	"cosmossdk.io/x/nft"                  //nolint:staticcheck // deprecated and to be removed
+	nftkeeper "cosmossdk.io/x/nft/keeper" //nolint:staticcheck // deprecated and to be removed
+	nftmodule "cosmossdk.io/x/nft/module" //nolint:staticcheck // deprecated and to be removed
 	"cosmossdk.io/x/tx/signing"
 	"cosmossdk.io/x/upgrade"
 	upgradekeeper "cosmossdk.io/x/upgrade/keeper"
diff --git a/simapp/app_config.go b/simapp/app_config.go
@@ -36,8 +36,8 @@ import (
 	"cosmossdk.io/x/feegrant"
 	_ "cosmossdk.io/x/feegrant/module" // import for side-effects
 	"cosmossdk.io/x/nft"
-	_ "cosmossdk.io/x/nft/module" // import for side-effects
-	_ "cosmossdk.io/x/upgrade"    // import for side-effects
+	_ "cosmossdk.io/x/nft/module"
+	_ "cosmossdk.io/x/upgrade" // import for side-effects
 	upgradetypes "cosmossdk.io/x/upgrade/types"
 
 	"github.com/cosmos/cosmos-sdk/runtime"
diff --git a/x/README.md b/x/README.md
@@ -34,7 +34,6 @@ capabilities of your blockchain or further specialize it.
 * [Authz](./authz/README.md) - Authorization for accounts to perform actions on behalf of other accounts.
 * [Epochs](./epochs/README.md) - Registration so SDK modules can have logic to be executed at the timed tickers.
 * [Feegrant](./feegrant/README.md) - Grant fee allowances for executing transactions.
-* [NFT](./nft/README.md) - NFT module implemented based on [ADR43](https://docs.cosmos.network/main/architecture/adr-043-nft-module.html).
 * [ProtocolPool](./protocolpool/README.md) - Extended management of community pool functionality.
 
 ## Deprecated Modules
@@ -44,6 +43,7 @@ in an upcoming release of the Cosmos SDK per our [release process](https://githu
 
 * [Crisis](./crisis/README.md) - *Deprecated* halting the blockchain under certain circumstances (e.g. if an invariant is broken).
 * [Params](./params/README.md) - *Deprecated* Globally available parameter store.
+* [NFT](./nft/README.md) - *Deprecated* NFT module implemented based on [ADR43](https://docs.cosmos.network/main/architecture/adr-043-nft-module.html).  This module will be moved to the `cosmos-sdk-legacy` repo for use.
 * [Group](./group/README.md) - *Deprecated* Allows for the creation and management of on-chain multisig accounts.  This module will be moved to the `cosmos-sdk-legacy` repo for legacy use.
 
 To learn more about the process of building modules, visit the [building modules reference documentation](https://docs.cosmos.network/main/building-modules/intro).
diff --git a/x/nft/README.md b/x/nft/README.md
@@ -4,6 +4,8 @@ sidebar_position: 1
 
 # `x/nft`
 
+⚠️ **DEPRECATED**: This package is deprecated and will be removed in the next major release.  The `x/nft` module will be moved to a separate repo `github.com/cosmos/cosmos-sdk-legacy`.
+
 ## Contents
 
 ## Abstract
diff --git a/x/nft/keeper/class.go b/x/nft/keeper/class.go
@@ -5,7 +5,7 @@ import (
 
 	"cosmossdk.io/errors"
 	storetypes "cosmossdk.io/store/types"
-	"cosmossdk.io/x/nft"
+	"cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed
 
 	"github.com/cosmos/cosmos-sdk/runtime"
 )
diff --git a/x/nft/keeper/genesis.go b/x/nft/keeper/genesis.go
@@ -3,7 +3,7 @@ package keeper
 import (
 	"sort"
 
-	"cosmossdk.io/x/nft"
+	"cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
 )
diff --git a/x/nft/keeper/grpc_query.go b/x/nft/keeper/grpc_query.go
@@ -4,7 +4,7 @@ import (
 	"context"
 
 	"cosmossdk.io/store/prefix"
-	"cosmossdk.io/x/nft"
+	"cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed
 
 	"github.com/cosmos/cosmos-sdk/runtime"
 	sdk "github.com/cosmos/cosmos-sdk/types"
diff --git a/x/nft/keeper/grpc_query_test.go b/x/nft/keeper/grpc_query_test.go
@@ -8,7 +8,7 @@ import (
 	"github.com/stretchr/testify/require"
 	"github.com/stretchr/testify/suite"
 
-	"cosmossdk.io/x/nft"
+	"cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed
 
 	"github.com/cosmos/cosmos-sdk/codec/address"
 )
diff --git a/x/nft/keeper/keeper.go b/x/nft/keeper/keeper.go
@@ -1,9 +1,10 @@
+// Deprecated: This package is deprecated and will be removed in the next major release. The `x/nft` module will be moved to a separate repo `github.com/cosmos/cosmos-sdk-legacy`.
 package keeper
 
 import (
 	"cosmossdk.io/core/address"
 	store "cosmossdk.io/core/store"
-	"cosmossdk.io/x/nft"
+	"cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed
 
 	"github.com/cosmos/cosmos-sdk/codec"
 )
diff --git a/x/nft/keeper/keeper_test.go b/x/nft/keeper/keeper_test.go
@@ -9,9 +9,9 @@ import (
 	"go.uber.org/mock/gomock"
 
 	storetypes "cosmossdk.io/store/types"
-	"cosmossdk.io/x/nft"
-	"cosmossdk.io/x/nft/keeper"
-	"cosmossdk.io/x/nft/module"
+	"cosmossdk.io/x/nft"        //nolint:staticcheck // deprecated and to be removed
+	"cosmossdk.io/x/nft/keeper" //nolint:staticcheck // deprecated and to be removed
+	"cosmossdk.io/x/nft/module" //nolint:staticcheck // deprecated and to be removed
 	nfttestutil "cosmossdk.io/x/nft/testutil"
 
 	"github.com/cosmos/cosmos-sdk/baseapp"
diff --git a/x/nft/keeper/keys.go b/x/nft/keeper/keys.go
@@ -3,7 +3,7 @@ package keeper
 import (
 	"bytes"
 
-	"cosmossdk.io/x/nft"
+	"cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed
 	"cosmossdk.io/x/nft/internal/conv"
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
diff --git a/x/nft/keeper/msg_server.go b/x/nft/keeper/msg_server.go
@@ -5,7 +5,7 @@ import (
 	"context"
 
 	errorsmod "cosmossdk.io/errors"
-	"cosmossdk.io/x/nft"
+	"cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
diff --git a/x/nft/keeper/msg_server_test.go b/x/nft/keeper/msg_server_test.go
@@ -3,7 +3,7 @@ package keeper_test
 import (
 	"fmt"
 
-	"cosmossdk.io/x/nft"
+	"cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed
 )
 
 var (
diff --git a/x/nft/keeper/nft.go b/x/nft/keeper/nft.go
@@ -5,7 +5,7 @@ import (
 
 	"cosmossdk.io/errors"
 	"cosmossdk.io/store/prefix"
-	"cosmossdk.io/x/nft"
+	"cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed
 
 	"github.com/cosmos/cosmos-sdk/runtime"
 	sdk "github.com/cosmos/cosmos-sdk/types"
diff --git a/x/nft/keeper/nft_batch.go b/x/nft/keeper/nft_batch.go
@@ -4,7 +4,7 @@ import (
 	"context"
 
 	"cosmossdk.io/errors"
-	"cosmossdk.io/x/nft"
+	"cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
 )
diff --git a/x/nft/keeper/nft_batch_test.go b/x/nft/keeper/nft_batch_test.go
@@ -4,7 +4,7 @@ import (
 	"fmt"
 	"math/rand"
 
-	"cosmossdk.io/x/nft"
+	"cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed
 )
 
 func (s *TestSuite) TestBatchMint() {
diff --git a/x/nft/keys.go b/x/nft/keys.go
@@ -1,3 +1,4 @@
+// Deprecated: This package is deprecated and will be removed in the next major release. The `x/nft` module will be moved to a separate repo `github.com/cosmos/cosmos-sdk-legacy`.
 package nft
 
 const (
diff --git a/x/nft/module/autocli.go b/x/nft/module/autocli.go
@@ -1,11 +1,12 @@
+// Deprecated: This package is deprecated and will be removed in the next major release. The `x/nft` module will be moved to a separate repo `github.com/cosmos/cosmos-sdk-legacy`.
 package module
 
 import (
 	"fmt"
 
 	autocliv1 "cosmossdk.io/api/cosmos/autocli/v1"
 	nftv1beta1 "cosmossdk.io/api/cosmos/nft/v1beta1"
-	"cosmossdk.io/x/nft"
+	"cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed
 
 	"github.com/cosmos/cosmos-sdk/version"
 )
diff --git a/x/nft/module/module.go b/x/nft/module/module.go
@@ -13,9 +13,9 @@ import (
 	"cosmossdk.io/core/store"
 	"cosmossdk.io/depinject"
 	"cosmossdk.io/errors"
-	"cosmossdk.io/x/nft"
-	"cosmossdk.io/x/nft/keeper"
-	"cosmossdk.io/x/nft/simulation"
+	"cosmossdk.io/x/nft"            //nolint:staticcheck // deprecated and to be removed
+	"cosmossdk.io/x/nft/keeper"     //nolint:staticcheck // deprecated and to be removed
+	"cosmossdk.io/x/nft/simulation" //nolint:staticcheck // deprecated and to be removed
 
 	sdkclient "github.com/cosmos/cosmos-sdk/client"
 	"github.com/cosmos/cosmos-sdk/codec"
diff --git a/x/nft/simulation/decoder.go b/x/nft/simulation/decoder.go
@@ -1,11 +1,12 @@
+// Deprecated: This package is deprecated and will be removed in the next major release. The `x/nft` module will be moved to a separate repo `github.com/cosmos/cosmos-sdk-legacy`.
 package simulation
 
 import (
 	"bytes"
 	"fmt"
 
-	"cosmossdk.io/x/nft"
-	"cosmossdk.io/x/nft/keeper"
+	"cosmossdk.io/x/nft"        //nolint:staticcheck // deprecated and to be removed
+	"cosmossdk.io/x/nft/keeper" //nolint:staticcheck // deprecated and to be removed
 
 	"github.com/cosmos/cosmos-sdk/codec"
 	sdk "github.com/cosmos/cosmos-sdk/types"
diff --git a/x/nft/simulation/decoder_test.go b/x/nft/simulation/decoder_test.go
@@ -6,10 +6,10 @@ import (
 
 	"github.com/stretchr/testify/require"
 
-	"cosmossdk.io/x/nft"
-	"cosmossdk.io/x/nft/keeper"
-	"cosmossdk.io/x/nft/module"
-	"cosmossdk.io/x/nft/simulation"
+	"cosmossdk.io/x/nft"            //nolint:staticcheck // deprecated and to be removed
+	"cosmossdk.io/x/nft/keeper"     //nolint:staticcheck // deprecated and to be removed
+	"cosmossdk.io/x/nft/module"     //nolint:staticcheck // deprecated and to be removed
+	"cosmossdk.io/x/nft/simulation" //nolint:staticcheck // deprecated and to be removed
 
 	"github.com/cosmos/cosmos-sdk/crypto/keys/ed25519"
 	sdk "github.com/cosmos/cosmos-sdk/types"
diff --git a/x/nft/simulation/genesis.go b/x/nft/simulation/genesis.go
@@ -4,7 +4,7 @@ import (
 	"math/rand"
 
 	"cosmossdk.io/core/address"
-	"cosmossdk.io/x/nft"
+	"cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed
 
 	"github.com/cosmos/cosmos-sdk/types/module"
 	simtypes "github.com/cosmos/cosmos-sdk/types/simulation"
diff --git a/x/nft/simulation/genesis_test.go b/x/nft/simulation/genesis_test.go
@@ -8,9 +8,9 @@ import (
 	"github.com/stretchr/testify/require"
 
 	sdkmath "cosmossdk.io/math"
-	"cosmossdk.io/x/nft"
-	nftmodule "cosmossdk.io/x/nft/module"
-	"cosmossdk.io/x/nft/simulation"
+	"cosmossdk.io/x/nft"                  //nolint:staticcheck // deprecated and to be removed
+	nftmodule "cosmossdk.io/x/nft/module" //nolint:staticcheck // deprecated and to be removed
+	"cosmossdk.io/x/nft/simulation"       //nolint:staticcheck // deprecated and to be removed
 
 	addresscodec "github.com/cosmos/cosmos-sdk/codec/address"
 	"github.com/cosmos/cosmos-sdk/types/module"
diff --git a/x/nft/simulation/msg_factory.go b/x/nft/simulation/msg_factory.go
@@ -3,8 +3,8 @@ package simulation
 import (
 	"context"
 
-	"cosmossdk.io/x/nft"
-	"cosmossdk.io/x/nft/keeper"
+	"cosmossdk.io/x/nft"        //nolint:staticcheck // deprecated and to be removed
+	"cosmossdk.io/x/nft/keeper" //nolint:staticcheck // deprecated and to be removed
 
 	"github.com/cosmos/cosmos-sdk/testutil/simsx"
 	sdk "github.com/cosmos/cosmos-sdk/types"
diff --git a/x/nft/simulation/operations.go b/x/nft/simulation/operations.go
@@ -3,8 +3,8 @@ package simulation
 import (
 	"math/rand"
 
-	"cosmossdk.io/x/nft"
-	"cosmossdk.io/x/nft/keeper"
+	"cosmossdk.io/x/nft"        //nolint:staticcheck // deprecated and to be removed
+	"cosmossdk.io/x/nft/keeper" //nolint:staticcheck // deprecated and to be removed
 
 	"github.com/cosmos/cosmos-sdk/baseapp"
 	"github.com/cosmos/cosmos-sdk/client"
diff --git a/x/nft/simulation/operations_test.go b/x/nft/simulation/operations_test.go
@@ -10,9 +10,9 @@ import (
 
 	"cosmossdk.io/depinject"
 	"cosmossdk.io/log"
-	"cosmossdk.io/x/nft"
-	nftkeeper "cosmossdk.io/x/nft/keeper"
-	"cosmossdk.io/x/nft/simulation"
+	"cosmossdk.io/x/nft"                  //nolint:staticcheck // deprecated and to be removed
+	nftkeeper "cosmossdk.io/x/nft/keeper" //nolint:staticcheck // deprecated and to be removed
+	"cosmossdk.io/x/nft/simulation"       //nolint:staticcheck // deprecated and to be removed
 	"cosmossdk.io/x/nft/testutil"
 
 	"github.com/cosmos/cosmos-sdk/client"
diff --git a/x/nft/testutil/app_config.go b/x/nft/testutil/app_config.go
@@ -1,7 +1,7 @@
 package testutil
 
 import (
-	_ "cosmossdk.io/x/nft/module" // import as blank for app wiring
+	_ "cosmossdk.io/x/nft/module" //nolint:staticcheck // deprecated and to be removed // import as blank for app wiring
 
 	"github.com/cosmos/cosmos-sdk/testutil/configurator"
 	_ "github.com/cosmos/cosmos-sdk/x/auth"           // import as blank for app wiring

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ import (`
`5`	`5`
`6`	`6`	`"cosmossdk.io/errors"`
`7`	`7`	`storetypes "cosmossdk.io/store/types"`
`8`		`- "cosmossdk.io/x/nft"`
	`8`	`+ "cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed`
`9`	`9`
`10`	`10`	`"github.com/cosmos/cosmos-sdk/runtime"`
`11`	`11`	`)`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ package keeper`
`3`	`3`	`import (`
`4`	`4`	`"sort"`
`5`	`5`
`6`		`- "cosmossdk.io/x/nft"`
	`6`	`+ "cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed`
`7`	`7`
`8`	`8`	`sdk "github.com/cosmos/cosmos-sdk/types"`
`9`	`9`	`)`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ import (`
`8`	`8`	`"github.com/stretchr/testify/require"`
`9`	`9`	`"github.com/stretchr/testify/suite"`
`10`	`10`
`11`		`- "cosmossdk.io/x/nft"`
	`11`	`+ "cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed`
`12`	`12`
`13`	`13`	`"github.com/cosmos/cosmos-sdk/codec/address"`
`14`	`14`	`)`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ package keeper_test`
`3`	`3`	`import (`
`4`	`4`	`"fmt"`
`5`	`5`
`6`		`- "cosmossdk.io/x/nft"`
	`6`	`+ "cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed`
`7`	`7`	`)`
`8`	`8`
`9`	`9`	`var (`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ import (`
`4`	`4`	`"context"`
`5`	`5`
`6`	`6`	`"cosmossdk.io/errors"`
`7`		`- "cosmossdk.io/x/nft"`
	`7`	`+ "cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed`
`8`	`8`
`9`	`9`	`sdk "github.com/cosmos/cosmos-sdk/types"`
`10`	`10`	`)`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ import (`
`4`	`4`	`"fmt"`
`5`	`5`	`"math/rand"`
`6`	`6`
`7`		`- "cosmossdk.io/x/nft"`
	`7`	`+ "cosmossdk.io/x/nft" //nolint:staticcheck // deprecated and to be removed`
`8`	`8`	`)`
`9`	`9`
`10`	`10`	`func (s *TestSuite) TestBatchMint() {`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	+// Deprecated: This package is deprecated and will be removed in the next major release. The `x/nft` module will be moved to a separate repo `github.com/cosmos/cosmos-sdk-legacy`.
`1`	`2`	`package nft`
`2`	`3`
`3`	`4`	`const (`