-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(x/mint): Add max supply param (backport #19896) #25599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yihuang
wants to merge
17
commits into
cosmos:main
Choose a base branch
from
yihuang:max-supply
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+377
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marko <[email protected]> remove cherry-pick commet errors fix test fix v3 migrate simplify the condition cleanup logic Problem: minted coin could be negative Solution: - stop minting if total supply already exceeds max supply
yihuang
commented
Nov 24, 2025
Contributor
|
@yihuang CI is broken |
Contributor
Author
I'm not sure how to handle the api package dependency, if we replace it to local directory, it'll complain |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25599 +/- ##
==========================================
- Coverage 70.30% 70.27% -0.03%
==========================================
Files 821 822 +1
Lines 53768 53797 +29
==========================================
+ Hits 37803 37808 +5
- Misses 15965 15989 +24
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Co-authored-by: Marko [email protected]