Use Authority Params #25607
Open
Use Authority Params #25607
+4,028
−2,667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/authority-params
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:x/distribution
github-actions
bot
added
C:x/genutil
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25607 +/- ##
==========================================
- Coverage 69.95% 68.34% -1.61%
==========================================
Files 826 856 +30
Lines 54222 55799 +1577
==========================================
+ Hits 37929 38138 +209
- Misses 16293 17661 +1368
... and 43 files with indirect coverage changes 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if keys[consensusparamtypes.StoreKey] != nil { | ||
| // set baseApp param store | ||
| consensusParamsKeeper := consensusparamkeeper.NewKeeper(appCodec, runtime.NewKVStoreService(keys[consensusparamtypes.StoreKey]), authtypes.NewModuleAddress("gov").String(), runtime.EventService{}) | ||
| consensusParamsKeeper := consensusparamkeeper.NewKeeper(appCodec, runtime.NewKVStoreService(keys[consensusparamtypes.StoreKey]), runtime.EventService{}, authcodec.NewBech32Codec(sdk.Bech32MainPrefix)) |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially closes: https://linear.app/cosmoslabs/issue/STACK-1856/replace-authority-keeper-params-with-consensus-parameters-authority
needs this PR merged first: cometbft/cometbft#5511