Skip to content

chore: separated deprecated modules into the contrib directory #25613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: separated deprecated modules into the contrib directory #25613

wants to merge 6 commits into from

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Nov 27, 2025 •
edited
Loading

Description

Problem:

  • when new fields (such as max_supply) are added to proto files, we need api replacement (cosmossdk.io/api => ../api) to use the latest generated API files.
  • modules like nft or crisis have been removed from api/cosmos, builds will fail due to missing packages.

Solution:

  • separate deprecated modules into the contrib, distinct from api, to enable and unblock new proto changes without affecting legacy code.

@codecov
Copy link

codecov bot commented Nov 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.89%. Comparing base (ca3241e) to head (0f92fd6).

Files with missing lines Patch % Lines
contrib/x/circuit/autocli.go 0.00% 2 Missing ⚠️
contrib/x/crisis/autocli.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #25613      +/-   ##
==========================================
+ Coverage   70.30%   70.89%   +0.58%     
==========================================
  Files         821      850      +29     
  Lines       53768    55893    +2125     
==========================================
+ Hits        37803    39624    +1821     
- Misses      15965    16269     +304
Files with missing lines Coverage Δ
contrib/x/circuit/module.go 0.00% <ø> (ø)
contrib/x/crisis/keeper/migrator.go 0.00% <ø> (ø)
contrib/x/crisis/module.go 0.00% <ø> (ø)
contrib/x/group/client/cli/tx.go 77.92% <100.00%> (ø)
contrib/x/group/codec.go 100.00% <100.00%> (ø)
contrib/x/group/keeper/migrations.go 0.00% <ø> (ø)
contrib/x/group/module/autocli.go 100.00% <100.00%> (ø)
contrib/x/group/module/module.go 46.25% <ø> (ø)
contrib/x/nft/module/autocli.go 0.00% <ø> (ø)
contrib/x/nft/module/module.go 0.00% <ø> (ø)
... and 3 more

... and 31 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmsqe mmsqe changed the title chore: x/group is not cleaned up chore: separate deprecated contrib with api module Nov 27, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 27, 2025
View reviewed changes
contrib/contrib/circuit/module/v1/module.pulsar.go
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
contrib/contrib/circuit/v1/types.pulsar.go
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
contrib/contrib/crisis/module/v1/module.pulsar.go
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
contrib/contrib/crisis/v1beta1/genesis.pulsar.go
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
@mmsqe
less diff
792ed49 
fix path
@github-actions github-actions bot removed the C:x/genutil genutil module issues label Nov 28, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2025
View reviewed changes
contrib/contrib/crisis/v1beta1/tx.pulsar.go
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
contrib/contrib/group/module/v1/module.pulsar.go
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
durationpb "google.golang.org/protobuf/types/known/durationpb"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
contrib/contrib/group/v1/genesis.pulsar.go
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
contrib/contrib/nft/module/v1/module.pulsar.go
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
contrib/contrib/nft/v1beta1/event.pulsar.go
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
contrib/contrib/nft/v1beta1/genesis.pulsar.go
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
contrib/contrib/nft/v1beta1/nft.pulsar.go
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
anypb "google.golang.org/protobuf/types/known/anypb"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
contrib/contrib/nft/v1beta1/tx.pulsar.go
protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
@mmsqe mmsqe changed the title chore: separate deprecated contrib with api module chore: separated deprecated modules into the contrib directory Nov 28, 2025
@mmsqe mmsqe marked this pull request as ready for review November 28, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

C:CLI C:x/tx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mmsqe