chore(gov): make distribution keeper optional #25616
Open
+49
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omits the use of the staking keeper entirely, unless specifically required in the function
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25616 +/- ##
==========================================
- Coverage 70.30% 70.30% -0.01%
==========================================
Files 821 821
Lines 53768 53771 +3
==========================================
+ Hits 37803 37805 +2
- Misses 15965 15966 +1
🚀 New features to boost your workflow:
|
aljo242
reviewed
Nov 27, 2025
aljo242
reviewed
Nov 27, 2025
Contributor
aljo242
left a comment
aljo242
left a comment
There was a problem hiding this comment.
Feels like we need to test an e2e app with no distribution in our system tests or large e2e setups
vladjdk
force-pushed
the
vlad/decouple-gov-distr
branch
2 times, most recently
from
2dfde55 to
bfa4c80
Compare
vladjdk
force-pushed
the
vlad/decouple-gov-distr
branch
from
bfa4c80 to
1976044
Compare
aljo242
reviewed
Nov 27, 2025
| v1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1" | ||
| ) | ||
|
|
||
| func (suite *KeeperTestSuite) TestImportExportQueues_ErrorUnconsistentState() { |
Contributor
There was a problem hiding this comment.
Follow up item should be to test this function more thoroughly
aljo242
approved these changes
Nov 27, 2025
Member
Author
aljo242
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes distribution keeper optional. Requires that the distribution keeper is non-nil if the module's address is used as a cancellation fee destination.
Requires #25615 to be merged first.