-
Notifications
You must be signed in to change notification settings - Fork 128
fix: evm tx index and log indexes are not patched #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
==========================================
- Coverage 65.24% 65.23% -0.01%
==========================================
Files 317 317
Lines 21612 21654 +42
==========================================
+ Hits 14101 14127 +26
- Misses 6351 6362 +11
- Partials 1160 1165 +5
🚀 New features to boost your workflow:
|
* align patch * cleanup
|
thanks for opening this @mmsqe - could you give some more context on these changes? |
| return nil, fmt.Errorf("failed to convert tx result to eth receipt: %w", err) | ||
| } | ||
|
|
||
| if txResult.EthTxIndex == -1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we write a brief comment on why we are doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean add back this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch