Skip to content

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Nov 7, 2025

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@mmsqe mmsqe marked this pull request as ready for review November 7, 2025 02:09
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 73.33333% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.23%. Comparing base (7e3ac37) to head (a436262).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/vm/types/response.go 84.00% 4 Missing and 4 partials ⚠️
rpc/backend/comet_to_eth.go 0.00% 4 Missing and 1 partial ⚠️
rpc/backend/tx_info.go 0.00% 4 Missing ⚠️
rpc/backend/utils.go 75.00% 1 Missing and 1 partial ⚠️
ante/cosmos/eip712.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   65.24%   65.23%   -0.01%     
==========================================
  Files         317      317              
  Lines       21612    21654      +42     
==========================================
+ Hits        14101    14127      +26     
- Misses       6351     6362      +11     
- Partials     1160     1165       +5     
Files with missing lines Coverage Δ
ante/evm/fee_checker.go 71.83% <100.00%> (ø)
ante/evm/mono_decorator.go 79.41% <ø> (-0.16%) ⬇️
ethereum/eip712/encoding.go 78.18% <100.00%> (ø)
ethereum/eip712/encoding_legacy.go 75.18% <100.00%> (ø)
rpc/types/events.go 77.98% <100.00%> (+0.41%) ⬆️
x/vm/keeper/abci.go 89.47% <ø> (-0.53%) ⬇️
x/vm/keeper/config.go 92.59% <100.00%> (ø)
x/vm/keeper/keeper.go 81.59% <ø> (-0.17%) ⬇️
x/vm/keeper/state_transition.go 83.50% <ø> (-0.06%) ⬇️
ante/cosmos/eip712.go 3.10% <0.00%> (ø)
... and 4 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* align patch
* cleanup
@aljo242
Copy link
Contributor

aljo242 commented Nov 7, 2025

thanks for opening this @mmsqe - could you give some more context on these changes?

@mmsqe
Copy link
Contributor Author

mmsqe commented Nov 7, 2025

thanks for opening this @mmsqe - could you give some more context on these changes?

yes, the remove of transient store and EmitTxHashEvent is mentioned in the origin context for parallel tx execution.

return nil, fmt.Errorf("failed to convert tx result to eth receipt: %w", err)
}

if txResult.EthTxIndex == -1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we write a brief comment on why we are doing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean add back this comment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

"io"
"os"

goruntime "runtime"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants