feat(rpc): add OpenTelemetry tracing #863
Draft
+1,331
−640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technicallyty
changed the title
swift1337
reviewed
Nov 28, 2025
|
|
||
| import "go.opentelemetry.io/otel" | ||
|
|
||
| var tracer = otel.Tracer("evm/rpc/backend") |
Member
There was a problem hiding this comment.
let's drop this file and move this to backend.go
| func (b *Backend) GetCode(address common.Address, blockNrOrHash rpctypes.BlockNumberOrHash) (hexutil.Bytes, error) { | ||
| blockNum, err := b.BlockNumberFromComet(blockNrOrHash) | ||
| func (b *Backend) GetCode(ctx context.Context, address common.Address, blockNrOrHash rpctypes.BlockNumberOrHash) (bz hexutil.Bytes, err error) { | ||
| ctx, span := tracer.Start(ctx, "GetCode", trace.WithAttributes(attribute.String("address", address.String()), attribute.String("blockNorHash", unwrapBlockNOrHash(blockNrOrHash)))) |
Member
There was a problem hiding this comment.
I see a lot of repeated code that can be simplified with a small wrapper. Consider the following:
Creating span for existing ctx:
// wrapper would be located here:
// import https://github.com/cosmos/evm/trace
// func Start(ctx context.Context, name string, attr... Attribute)
// trace.Str supports string or Stringable
// trace.Block automatically parses block or hash
// ... other cosmos/evm specific attrs
ctx, span := trace.Start(ctx, "GetCode", trace.Str("address", address), trace.Block("block", blockNrOrHash))
// regular span end
defer span.End()
// captures err if not nil
defer span.EndErr(err)
Member
There was a problem hiding this comment.
Creating span for new ctx:
ctx, span := trace.StartNew("GetCode", attrs...)
defer span.End()| "github.com/cosmos/cosmos-sdk/server" | ||
| ) | ||
|
|
||
| var tracer = otel.Tracer("evm/rpc/namespaces/ethereum/debug") |
Member
There was a problem hiding this comment.
same approach:
// import github.com/cosmos/evm/trace
var tracer = trace.New("evm/rpc/namespaces/ethereum/debug")
Member
|
Curious, where do we configure tracing sampling rate here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds otel tracers to the RPC package.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch