chore(simapp): remove dead intra-tx counter and fix misleading comment in zero-height export #8685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in zero-height export
…t in zero-height export
…t in zero-height export
|
can you create a detailed issue explaining this? |
Yes, i'm gonna do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed an unused counter variable and its increment from the validator iteration in prepForZeroHeightGenesis() and updated the comment to accurately reflect behavior (only resetting bond heights). This dead code was a legacy artifact; no code reads the counter, and modern staking does not use a “bond intra-tx counter.” The change clarifies intent and avoids confusion