Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify which events must be emitted on IBC msgs #606

Open
AdityaSripal opened this issue Oct 7, 2021 · 5 comments · May be fixed by #981
Open

Specify which events must be emitted on IBC msgs #606

AdityaSripal opened this issue Oct 7, 2021 · 5 comments · May be fixed by #981
Assignees
Labels
implementation Tracking an external implementation of the spec.

Comments

@AdityaSripal
Copy link
Member

No description provided.

@AdityaSripal AdityaSripal self-assigned this Oct 7, 2021
@ethanfrey
Copy link
Contributor

There is some very clear Go code for this: https://github.com/cosmos/ibc-go/blob/main/modules/core/04-channel/keeper/events.go

I would be happy just adding those to the spec, so it is clear for other implementations.

@ethanfrey
Copy link
Contributor

Or... we decide these events are not part of the spec?

@AdityaSripal
Copy link
Member Author

Definitely the events relayers should expect need to be part of the spec. Otherwise relayers will have to implement different parsing logic for each implementation. We should standardize on the format that relayers can expect

@tac0turtle
Copy link
Member

Has there been research into how other protocols emit events?

Dont want to tie other protocols into cosmos style events, since IBC is generally agnositc.

@mpoke
Copy link
Contributor

mpoke commented Mar 17, 2022

@AdityaSripal I guess this is connected to #534, right?

@mpoke mpoke added the implementation Tracking an external implementation of the spec. label Mar 17, 2022
@crodriguezvega crodriguezvega linked a pull request Jun 9, 2023 that will close this issue
@crodriguezvega crodriguezvega linked a pull request Jun 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation Tracking an external implementation of the spec.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants